This is an automated email from the ASF dual-hosted git repository. beto pushed a commit to branch sc_74037 in repository https://gitbox.apache.org/repos/asf/superset.git
commit 4af599d0253442721717a9d8ccf3304b72a8bff4 Author: Beto Dealmeida <[email protected]> AuthorDate: Tue Sep 26 13:49:39 2023 -0700 Increase code coverage --- superset-frontend/jest.config.js | 3 ++ .../formatters/finestTemporalGrain.test.ts | 43 ++++++++++++++++++---- 2 files changed, 38 insertions(+), 8 deletions(-) diff --git a/superset-frontend/jest.config.js b/superset-frontend/jest.config.js index 24e4886ecd..316102c5c2 100644 --- a/superset-frontend/jest.config.js +++ b/superset-frontend/jest.config.js @@ -17,6 +17,9 @@ * under the License. */ +// timezone for unit tests +process.env.TZ = 'America/New_York'; + module.exports = { testRegex: '\\/superset-frontend\\/(spec|src|plugins|packages|tools)\\/.*(_spec|\\.test)\\.[jt]sx?$', diff --git a/superset-frontend/packages/superset-ui-core/src/time-format/formatters/finestTemporalGrain.test.ts b/superset-frontend/packages/superset-ui-core/src/time-format/formatters/finestTemporalGrain.test.ts index 2a39e3edb0..6e4f07df4b 100644 --- a/superset-frontend/packages/superset-ui-core/src/time-format/formatters/finestTemporalGrain.test.ts +++ b/superset-frontend/packages/superset-ui-core/src/time-format/formatters/finestTemporalGrain.test.ts @@ -21,16 +21,43 @@ import finestTemporalGrain from './finestTemporalGrain'; test('finestTemporalGrain', () => { const monthFormatter = finestTemporalGrain([ - 1041379200000, // 2003-01-01 00:00:00Z - 1044057600000, // 2003-02-01 00:00:00Z + new Date('2003-01-01 00:00:00Z').getTime(), + new Date('2003-02-01 00:00:00Z').getTime(), ]); - expect(monthFormatter(1041379200000)).toBe('2003-01-01'); - expect(monthFormatter(1044057600000)).toBe('2003-02-01'); + expect(monthFormatter(new Date('2003-01-01 00:00:00Z').getTime())).toBe( + '2003-01-01', + ); + expect(monthFormatter(new Date('2003-02-01 00:00:00Z').getTime())).toBe( + '2003-02-01', + ); const yearFormatter = finestTemporalGrain([ - 1041379200000, // 2003-01-01 00:00:00Z - 1072915200000, // 2004-01-01 00:00:00Z + new Date('2003-01-01 00:00:00Z').getTime(), + new Date('2004-01-01 00:00:00Z').getTime(), ]); - expect(yearFormatter(1041379200000)).toBe('2003'); - expect(yearFormatter(1072915200000)).toBe('2004'); + expect(yearFormatter(new Date('2003-01-01 00:00:00Z').getTime())).toBe( + '2003', + ); + expect(yearFormatter(new Date('2004-01-01 00:00:00Z').getTime())).toBe( + '2004', + ); + + const milliSecondFormatter = finestTemporalGrain([ + new Date('2003-01-01 00:00:00Z').getTime(), + new Date('2003-04-05 06:07:08.123Z').getTime(), + ]); + expect(milliSecondFormatter(new Date('2003-01-01 00:00:00Z').getTime())).toBe( + '2003-01-01 00:00:00.000', + ); + + const localTimeFormatter = finestTemporalGrain( + [ + new Date('2003-01-01 00:00:00Z').getTime(), + new Date('2003-02-01 00:00:00Z').getTime(), + ], + true, + ); + expect(localTimeFormatter(new Date('2003-01-01 00:00:00Z').getTime())).toBe( + '2002-12-31 19:00', + ); });
