This is an automated email from the ASF dual-hosted git repository.

sophieyou pushed a commit to branch tooltip-copy-updates
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/tooltip-copy-updates by this 
push:
     new c33bffc4c1 Update sharedControls.tsx
c33bffc4c1 is described below

commit c33bffc4c1b35e572deb25f035b9f155126dee12
Author: yousoph <[email protected]>
AuthorDate: Wed Sep 27 21:44:46 2023 -0700

    Update sharedControls.tsx
---
 .../src/shared-controls/sharedControls.tsx                 | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git 
a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/sharedControls.tsx
 
b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/sharedControls.tsx
index abf5153bb0..91d3a04a61 100644
--- 
a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/sharedControls.tsx
+++ 
b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/sharedControls.tsx
@@ -198,11 +198,9 @@ const time_grain_sqla: 
SharedControlConfig<'SelectControl'> = {
       : 'P1D';
   },
   description: t(
-    'The time granularity for the visualization. This ' +
-      'applies a date transformation to alter ' +
-      'your time column and defines a new time granularity. ' +
-      'The options here are defined on a per database ' +
-      'engine basis in the Superset source code.',
+    'Select a time grain for the visualization. The ' +
+      'grain is the time interval represented by a ' +
+      'single point on the chart.',
   ),
   mapStateToProps: ({ datasource }) => ({
     choices: (datasource as Dataset)?.time_grain_sqla || [],
@@ -232,7 +230,7 @@ const time_range: SharedControlConfig<'DateFilterControl'> 
= {
   label: TIME_FILTER_LABELS.time_range,
   default: NO_TIME_RANGE, // this value is an empty filter constant so 
shouldn't translate it.
   description: t(
-    'The time range for the visualization. All relative times, e.g. "Last 
month", ' +
+    'This control filters the whole chart based on the selected time range. 
All relative times, e.g. "Last month", ' +
       '"Last 7 days", "now", etc. are evaluated on the server using the 
server\'s ' +
       'local time (sans timezone). All tooltips and placeholder times are 
expressed ' +
       'in UTC (sans timezone). The timestamps are then evaluated by the 
database ' +
@@ -248,14 +246,14 @@ const row_limit: SharedControlConfig<'SelectControl'> = {
   validators: [legacyValidateInteger],
   default: 10000,
   choices: formatSelectOptions(ROW_LIMIT_OPTIONS),
-  description: t('Limits the number of rows that get displayed.'),
+  description: t('Limits the number of the rows that are computed in the query 
that is the source of the data used for this chart.'),
 };
 
 const order_desc: SharedControlConfig<'CheckboxControl'> = {
   type: 'CheckboxControl',
   label: t('Sort Descending'),
   default: true,
-  description: t('Whether to sort descending or ascending'),
+  description: t('If enabled, this control sorts the results/values 
descending, otherwise it sorts the results ascending.'),
   visibility: ({ controls }) =>
     Boolean(
       controls?.timeseries_limit_metric.value &&

Reply via email to