This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch no-experimental-fetch
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 9201ecf558e8b8c11543936491d2e5e82cc94758
Author: Evan Rusackas <e...@rusackas.com>
AuthorDate: Thu Oct 12 16:57:11 2023 -0600
chore: adding 'no-experimental-fetch' node option on scripts, removing it
from docs
---
CONTRIBUTING.md | 12 ------------
superset-frontend/package.json | 6 +++---
2 files changed, 3 insertions(+), 15 deletions(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index d9e480ee95..08a71c455e 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -598,18 +598,6 @@ There are three types of assets you can build:
2. `npm run dev-server`: local development assets, with sourcemaps and hot
refresh support
3. `npm run build-instrumented`: instrumented application code for collecting
code coverage from Cypress tests
-If this type of error comes while building assets(i.e using above commands):
-
-```bash
-Error: You must provide the URL of lib/mappings.wasm by calling
SourceMapConsumer.initialize
-```
-
-Then put this:
-
-```bash
-export NODE_OPTIONS=--no-experimental-fetch
-```
-
#### Webpack dev server
The dev server by default starts at `http://localhost:9000` and proxies the
backend requests to `http://localhost:8088`.
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
index fec56fdb45..f96ac1ad8d 100644
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -38,9 +38,9 @@
"scripts": {
"_lint": "eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,tsx .",
"_prettier": "prettier
'./({src,spec,cypress-base,plugins,packages,.storybook}/**/*{.js,.jsx,.ts,.tsx,.css,.less,.scss,.sass}|package.json)'",
- "build": "cross-env NODE_OPTIONS=--max_old_space_size=8192
NODE_ENV=production BABEL_ENV=\"${BABEL_ENV:=production}\" webpack
--mode=production --color",
- "build-dev": "cross-env NODE_OPTIONS=--max_old_space_size=8192
NODE_ENV=development webpack --mode=development --color",
- "build-instrumented": "cross-env NODE_ENV=production
BABEL_ENV=instrumented webpack --mode=production --color",
+ "build": "cross-env NODE_OPTIONS=--max_old_space_size=8192
--no-experimental-fetch NODE_ENV=production
BABEL_ENV=\"${BABEL_ENV:=production}\" webpack --mode=production --color",
+ "build-dev": "cross-env NODE_OPTIONS=--max_old_space_size=8192
--no-experimental-fetch NODE_ENV=development webpack --mode=development
--color",
+ "build-instrumented": "cross-env NODE_OPTIONS=--no-experimental-fetch
NODE_ENV=production BABEL_ENV=instrumented webpack --mode=production --color",
"build-storybook": "build-storybook",
"check-translation": "prettier --check
../superset/translations/**/LC_MESSAGES/*.json",
"chromatic": "npx chromatic --skip 'dependabot/**' --only-changed",
