(superset) branch master updated: fix(explore): redandant force param (#25985)

[justinpark]

This is an automated email from the ASF dual-hosted git repository.

justinpark pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new e7a1876807 fix(explore): redandant force param (#25985)
e7a1876807 is described below

commit e7a187680713867f22b082f3bb0a57296d2a331c
Author: JUST.in DO IT <justin.p...@airbnb.com>
AuthorDate: Thu Nov 16 12:58:06 2023 -0800

    fix(explore): redandant force param (#25985)
---
 superset-frontend/src/components/Chart/Chart.jsx            | 2 +-
 superset-frontend/src/components/Chart/chartAction.js       | 2 +-
 superset-frontend/src/components/Chart/chartActions.test.js | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/superset-frontend/src/components/Chart/Chart.jsx 
b/superset-frontend/src/components/Chart/Chart.jsx
index af90ae6b0a..da9a81516f 100644
--- a/superset-frontend/src/components/Chart/Chart.jsx
+++ b/superset-frontend/src/components/Chart/Chart.jsx
@@ -169,7 +169,7 @@ class Chart extends React.PureComponent {
       // Create chart with POST request
       this.props.actions.postChartFormData(
         this.props.formData,
-        this.props.force || getUrlParam(URL_PARAMS.force), // allow override 
via url params force=true
+        Boolean(this.props.force || getUrlParam(URL_PARAMS.force)), // allow 
override via url params force=true
         this.props.timeout,
         this.props.chartId,
         this.props.dashboardId,
diff --git a/superset-frontend/src/components/Chart/chartAction.js 
b/superset-frontend/src/components/Chart/chartAction.js
index 9e5dc0eddd..42aa3fc5b1 100644
--- a/superset-frontend/src/components/Chart/chartAction.js
+++ b/superset-frontend/src/components/Chart/chartAction.js
@@ -183,7 +183,7 @@ const v1ChartDataRequest = async (
   const qs = {};
   if (sliceId !== undefined) qs.form_data = `{"slice_id":${sliceId}}`;
   if (dashboardId !== undefined) qs.dashboard_id = dashboardId;
-  if (force !== false) qs.force = force;
+  if (force) qs.force = force;
 
   const allowDomainSharding =
     // eslint-disable-next-line camelcase
diff --git a/superset-frontend/src/components/Chart/chartActions.test.js 
b/superset-frontend/src/components/Chart/chartActions.test.js
index 65b008de62..b44ca7c8d7 100644
--- a/superset-frontend/src/components/Chart/chartActions.test.js
+++ b/superset-frontend/src/components/Chart/chartActions.test.js
@@ -51,7 +51,7 @@ describe('chart actions', () => {
       .callsFake(() => MOCK_URL);
     getChartDataUriStub = sinon
       .stub(exploreUtils, 'getChartDataUri')
-      .callsFake(() => URI(MOCK_URL));
+      .callsFake(({ qs }) => URI(MOCK_URL).query(qs));
     fakeMetadata = { useLegacyApi: true };
     metadataRegistryStub = sinon
       .stub(chartlib, 'getChartMetadataRegistry')
@@ -81,7 +81,7 @@ describe('chart actions', () => {
     });
 
     it('should query with the built query', async () => {
-      const actionThunk = actions.postChartFormData({});
+      const actionThunk = actions.postChartFormData({}, null);
       await actionThunk(dispatch);
 
       expect(fetchMock.calls(MOCK_URL)).toHaveLength(1);