This is an automated email from the ASF dual-hosted git repository. michaelsmolina pushed a commit to branch 3.0 in repository https://gitbox.apache.org/repos/asf/superset.git
commit aaa458bf9def031c3f4186e1b416a00e74718cae Author: Vitor Avila <[email protected]> AuthorDate: Tue Dec 26 23:31:51 2023 -0300 chore(Embedded): Avoid creating a filter key for guest users (#26312) Co-authored-by: Michael S. Molina <[email protected]> (cherry picked from commit fe9fbadade9b5bfe57a4479adaf0e6a3b53aa6d7) --- .../src/dashboard/components/nativeFilters/FilterBar/index.tsx | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx index 25284126d0..61014a6e0f 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx @@ -47,6 +47,7 @@ import { useTabId } from 'src/hooks/useTabId'; import { logEvent } from 'src/logger/actions'; import { LOG_ACTIONS_CHANGE_DASHBOARD_FILTER } from 'src/logger/LogUtils'; import { FilterBarOrientation, RootState } from 'src/dashboard/types'; +import { UserWithPermissionsAndRoles } from 'src/types/bootstrapTypes'; import { checkIsApplyDisabled } from './utils'; import { FiltersBarProps } from './types'; import { @@ -149,6 +150,10 @@ const FilterBar: React.FC<FiltersBarProps> = ({ const canEdit = useSelector<RootState, boolean>( ({ dashboardInfo }) => dashboardInfo.dash_edit_perm, ); + const user: UserWithPermissionsAndRoles = useSelector< + RootState, + UserWithPermissionsAndRoles + >(state => state.user); const [filtersInScope] = useSelectFiltersInScope(nativeFilterValues); @@ -220,7 +225,10 @@ const FilterBar: React.FC<FiltersBarProps> = ({ }, [dataMaskAppliedText, setDataMaskSelected]); useEffect(() => { - publishDataMask(history, dashboardId, updateKey, dataMaskApplied, tabId); + // embedded users can't persist filter combinations + if (user?.userId) { + publishDataMask(history, dashboardId, updateKey, dataMaskApplied, tabId); + } // eslint-disable-next-line react-hooks/exhaustive-deps }, [dashboardId, dataMaskAppliedText, history, updateKey, tabId]);
