This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new eff4422d04 chore: Deprecates the DASHBOARD_CROSS_FILTERS feature flag
(#26633)
eff4422d04 is described below
commit eff4422d04ab27dc2074dcfa46a416f9170c73c6
Author: Michael S. Molina <70410625+michael-s-mol...@users.noreply.github.com>
AuthorDate: Wed Jan 17 13:01:27 2024 -0300
chore: Deprecates the DASHBOARD_CROSS_FILTERS feature flag (#26633)
---
RESOURCES/FEATURE_FLAGS.md | 2 +-
.../packages/superset-ui-core/src/utils/featureFlags.ts | 9 +++++----
superset/config.py | 2 +-
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md
index 577e47711c..bb1fc6204a 100644
--- a/RESOURCES/FEATURE_FLAGS.md
+++ b/RESOURCES/FEATURE_FLAGS.md
@@ -61,7 +61,6 @@ These features flags are **safe for production**. They have
been tested and will
- ALERTS_ATTACH_REPORTS
- ALLOW_ADHOC_SUBQUERY
-- DASHBOARD_CROSS_FILTERS
- DASHBOARD_RBAC
[(docs)](https://superset.apache.org/docs/creating-charts-dashboards/first-dashboard#manage-access-to-dashboards)
- DASHBOARD_VIRTUALIZATION
- DATAPANEL_CLOSED_BY_DEFAULT
@@ -84,6 +83,7 @@ These features flags currently default to True and **will be
removed in a future
[//]: # "PLEASE KEEP THE LIST SORTED ALPHABETICALLY"
+- DASHBOARD_CROSS_FILTERS
- DASHBOARD_FILTERS_EXPERIMENTAL
- DASHBOARD_NATIVE_FILTERS
- ENABLE_EXPLORE_JSON_CSRF_PROTECTION
diff --git
a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
index f4a2054dbf..cedc4064be 100644
--- a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
+++ b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
@@ -25,9 +25,11 @@ export enum FeatureFlag {
ALERTS_ATTACH_REPORTS = 'ALERTS_ATTACH_REPORTS',
ALERT_REPORTS = 'ALERT_REPORTS',
ALLOW_FULL_CSV_EXPORT = 'ALLOW_FULL_CSV_EXPORT',
+ AVOID_COLORS_COLLISION = 'AVOID_COLORS_COLLISION',
+ CONFIRM_DASHBOARD_DIFF = 'CONFIRM_DASHBOARD_DIFF',
+ /** @deprecated */
DASHBOARD_CROSS_FILTERS = 'DASHBOARD_CROSS_FILTERS',
DASHBOARD_FILTERS_EXPERIMENTAL = 'DASHBOARD_FILTERS_EXPERIMENTAL',
- CONFIRM_DASHBOARD_DIFF = 'CONFIRM_DASHBOARD_DIFF',
DASHBOARD_NATIVE_FILTERS = 'DASHBOARD_NATIVE_FILTERS',
DASHBOARD_VIRTUALIZATION = 'DASHBOARD_VIRTUALIZATION',
DASHBOARD_RBAC = 'DASHBOARD_RBAC',
@@ -53,12 +55,11 @@ export enum FeatureFlag {
SHARE_QUERIES_VIA_KV_STORE = 'SHARE_QUERIES_VIA_KV_STORE',
SQLLAB_BACKEND_PERSISTENCE = 'SQLLAB_BACKEND_PERSISTENCE',
SQL_VALIDATORS_BY_ENGINE = 'SQL_VALIDATORS_BY_ENGINE',
+ SSH_TUNNELING = 'SSH_TUNNELING',
+ TAGGING_SYSTEM = 'TAGGING_SYSTEM',
THUMBNAILS = 'THUMBNAILS',
USE_ANALAGOUS_COLORS = 'USE_ANALAGOUS_COLORS',
- TAGGING_SYSTEM = 'TAGGING_SYSTEM',
VERSIONED_EXPORT = 'VERSIONED_EXPORT',
- SSH_TUNNELING = 'SSH_TUNNELING',
- AVOID_COLORS_COLLISION = 'AVOID_COLORS_COLLISION',
}
export type ScheduleQueriesProps = {
JSONSCHEMA: {
diff --git a/superset/config.py b/superset/config.py
index 0259e4d50b..9cf53da067 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -439,7 +439,7 @@ DEFAULT_FEATURE_FLAGS: dict[str, bool] = {
# When True, this escapes HTML (rather than rendering it) in Markdown
components
"ESCAPE_MARKDOWN_HTML": False,
"DASHBOARD_NATIVE_FILTERS": True, # deprecated
- "DASHBOARD_CROSS_FILTERS": True,
+ "DASHBOARD_CROSS_FILTERS": True, # deprecated
"DASHBOARD_FILTERS_EXPERIMENTAL": False, # deprecated
"DASHBOARD_VIRTUALIZATION": True,
"GLOBAL_ASYNC_QUERIES": False,
