This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new be7c9490a1 chore(lint/a11y): fixing and locking down
jsx-a11y/anchor-is-valid (#26820)
be7c9490a1 is described below
commit be7c9490a168639504ba15c860c6c1b456938ea8
Author: Evan Rusackas <[email protected]>
AuthorDate: Mon Jan 29 11:58:37 2024 -0700
chore(lint/a11y): fixing and locking down jsx-a11y/anchor-is-valid (#26820)
---
superset-frontend/.eslintrc.js | 2 +-
superset-frontend/src/SqlLab/components/QueryLimitSelect/index.tsx | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js
index d533f61dad..5d15f87e42 100644
--- a/superset-frontend/.eslintrc.js
+++ b/superset-frontend/.eslintrc.js
@@ -116,7 +116,7 @@ module.exports = {
'import/no-named-as-default-member': 0,
'import/prefer-default-export': 0,
indent: 0,
- 'jsx-a11y/anchor-is-valid': 1,
+ 'jsx-a11y/anchor-is-valid': 2,
'jsx-a11y/click-events-have-key-events': 0, // re-enable up for
discussion
'jsx-a11y/mouse-events-have-key-events': 0, // re-enable up for
discussion
'max-classes-per-file': 0,
diff --git a/superset-frontend/src/SqlLab/components/QueryLimitSelect/index.tsx
b/superset-frontend/src/SqlLab/components/QueryLimitSelect/index.tsx
index 040910f9a8..3e8d1d2d2f 100644
--- a/superset-frontend/src/SqlLab/components/QueryLimitSelect/index.tsx
+++ b/superset-frontend/src/SqlLab/components/QueryLimitSelect/index.tsx
@@ -74,7 +74,7 @@ function renderQueryLimit(
{[...new Set(limitDropdown)].map(limit => (
<Menu.Item key={`${limit}`} onClick={() => setQueryLimit(limit)}>
{/* // eslint-disable-line no-use-before-define */}
- <a role="button">{convertToNumWithSpaces(limit)}</a>{' '}
+ {convertToNumWithSpaces(limit)}{' '}
</Menu.Item>
))}
</Menu>
