This is an automated email from the ASF dual-hosted git repository. rusackas pushed a commit to branch Lint-cleanup in repository https://gitbox.apache.org/repos/asf/superset.git
commit e4bc6ccd5a548b25f3631267947bfeb201fb2f3e Author: Evan Rusackas <[email protected]> AuthorDate: Thu Feb 15 13:29:26 2024 -0700 better comments, enabling a few rules. --- superset-frontend/.eslintrc.js | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js index 6ff6bc8a73..13b37a742f 100644 --- a/superset-frontend/.eslintrc.js +++ b/superset-frontend/.eslintrc.js @@ -162,7 +162,7 @@ module.exports = { 'react/static-property-placement': 0, // re-enable up for discussion 'prettier/prettier': 'error', 'file-progress/activate': 1, - // delete me later: temporary rules to help with migration + // TODO: temporary rules to help with migration - please re-enable! 'jsx-no-useless-fragment': 0, 'react/function-component-definition': [ 0, @@ -226,7 +226,7 @@ module.exports = { ], 'no-only-tests/no-only-tests': 'error', 'max-classes-per-file': 0, - // temporary rules to help with migration - please re-enable! + // TODO: temporary rules to help with migration - please re-enable! 'testing-library/await-async-queries': 0, 'testing-library/await-async-utils': 0, 'testing-library/no-await-sync-events': 0, @@ -261,6 +261,7 @@ module.exports = { 'theme-colors/no-literal-colors': 0, 'translation-vars/no-template-vars': 0, 'no-restricted-imports': 0, + // TODO: temporary rules to help with migration - please re-enable! 'jest/no-alias-methods': 0, 'react/no-void-elements': 0, }, @@ -351,8 +352,10 @@ module.exports = { 'react/static-property-placement': 0, // disabled temporarily 'react-prefer-function-component/react-prefer-function-component': 1, 'prettier/prettier': 'error', - // disabling some things that come with the eslint 7->8 upgrade. Will address these in a separate PR - 'jest/no-alias-methods': 0, + // TODO: temporary rules to help with migration - please re-enable! + 'jest/no-alias-methods': 2, + 'no-promise-executor-return': 2, + 'react/no-unused-class-component-methods': 2, 'react/no-unknown-property': 0, 'react/no-void-elements': 0, 'react/function-component-definition': [ @@ -367,8 +370,6 @@ module.exports = { 'no-import-assign': 0, 'import/no-relative-packages': 0, 'default-case-last': 0, - 'no-promise-executor-return': 0, - 'react/no-unused-class-component-methods': 0, }, ignorePatterns, };
