This is an automated email from the ASF dual-hosted git repository. michaelsmolina pushed a commit to branch 3.1 in repository https://gitbox.apache.org/repos/asf/superset.git
commit e80179a056d3bbf4617fe2eb9b619614f39c554f Author: Michael S. Molina <[email protected]> AuthorDate: Thu Feb 29 08:53:09 2024 -0500 fix: Data zoom with horizontal orientation (#27291) (cherry picked from commit 7854b622a34c9a9674e2c916acb8acbc63714fb8) --- .../plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts | 2 +- .../plugins/plugin-chart-echarts/src/Timeseries/transformers.ts | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts index 451685ec0a..78245cc9d9 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts @@ -575,7 +575,6 @@ export default function transformProps( right: TIMESERIES_CONSTANTS.toolboxRight, feature: { dataZoom: { - yAxisIndex: false, title: { zoom: t('zoom area'), back: t('restore zoom'), @@ -590,6 +589,7 @@ export default function transformProps( start: TIMESERIES_CONSTANTS.dataZoomStart, end: TIMESERIES_CONSTANTS.dataZoomEnd, bottom: TIMESERIES_CONSTANTS.zoomBottom, + yAxisIndex: isHorizontal ? 0 : undefined, }, ] : [], diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts index 5b9fa43047..be89fdfc74 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts @@ -570,9 +570,10 @@ export function getPadding( yAxisTitlePosition && yAxisTitlePosition === 'Top' ? TIMESERIES_CONSTANTS.gridOffsetTop + (Number(yAxisTitleMargin) || 0) : TIMESERIES_CONSTANTS.gridOffsetTop + yAxisOffset, - bottom: zoomable - ? TIMESERIES_CONSTANTS.gridOffsetBottomZoomable + xAxisOffset - : TIMESERIES_CONSTANTS.gridOffsetBottom + xAxisOffset, + bottom: + zoomable && !isHorizontal + ? TIMESERIES_CONSTANTS.gridOffsetBottomZoomable + xAxisOffset + : TIMESERIES_CONSTANTS.gridOffsetBottom + xAxisOffset, left: yAxisTitlePosition === 'Left' ? TIMESERIES_CONSTANTS.gridOffsetLeft +
