This is an automated email from the ASF dual-hosted git repository. michaelsmolina pushed a commit to branch 4.0 in repository https://gitbox.apache.org/repos/asf/superset.git
commit 336f6bd0219c43ce520357104158522164cc466f Author: Beto Dealmeida <[email protected]> AuthorDate: Thu Mar 21 17:09:40 2024 -0400 fix: sqlglot SQL Server (#27577) (cherry picked from commit 72a41c16424e86c92d7423aac7e9fbab505a2c37) --- superset/sql_parse.py | 2 +- tests/integration_tests/charts/data/api_tests.py | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/superset/sql_parse.py b/superset/sql_parse.py index 49ee4c491f..db51991e22 100644 --- a/superset/sql_parse.py +++ b/superset/sql_parse.py @@ -112,7 +112,7 @@ SQLGLOT_DIALECTS = { # "impala": ??? # "kustokql": ??? # "kylin": ??? - # "mssql": ??? + "mssql": Dialects.TSQL, "mysql": Dialects.MYSQL, "netezza": Dialects.POSTGRES, # "ocient": ??? diff --git a/tests/integration_tests/charts/data/api_tests.py b/tests/integration_tests/charts/data/api_tests.py index 7e5d4fda7f..f53ebeffb3 100644 --- a/tests/integration_tests/charts/data/api_tests.py +++ b/tests/integration_tests/charts/data/api_tests.py @@ -507,6 +507,9 @@ class TestPostChartDataApi(BaseTestChartDataApi): """ Chart data API: Ensure prophet post transformation works """ + if backend() == "hive": + return + time_grain = "P1Y" self.query_context_payload["queries"][0]["is_timeseries"] = True self.query_context_payload["queries"][0]["groupby"] = [] @@ -541,6 +544,9 @@ class TestPostChartDataApi(BaseTestChartDataApi): """ Chart data API: Ensure incorrect post processing returns correct response """ + if backend() == "hive": + return + query_context = self.query_context_payload query = query_context["queries"][0] query["columns"] = ["name", "gender"]
