This is an automated email from the ASF dual-hosted git repository. lilykuang pushed a commit to branch bar-chart-fix-legend-padding in repository https://gitbox.apache.org/repos/asf/superset.git
commit 1d75494d9e98f8329b201cf2b43297f3c2a64a18 Author: lilykuang <[email protected]> AuthorDate: Wed Apr 3 10:34:00 2024 -0700 fix(bar-chart): legend padding for horizontal orientation --- .../plugin-chart-echarts/src/Timeseries/transformers.ts | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts index b5ff791fbe..3b5cfd594a 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts @@ -563,6 +563,11 @@ export function getPadding( ? TIMESERIES_CONSTANTS.yAxisLabelTopOffset : 0; const xAxisOffset = addXAxisTitleOffset ? Number(xAxisTitleMargin) || 0 : 0; + const showLegendTopOffset = + isHorizontal && showLegend && legendOrientation === LegendOrientation.Top + ? 100 + : 0; + return getChartPadding( showLegend, legendOrientation, @@ -570,8 +575,12 @@ export function getPadding( { top: yAxisTitlePosition && yAxisTitlePosition === 'Top' - ? TIMESERIES_CONSTANTS.gridOffsetTop + (Number(yAxisTitleMargin) || 0) - : TIMESERIES_CONSTANTS.gridOffsetTop + yAxisOffset, + ? TIMESERIES_CONSTANTS.gridOffsetTop + + showLegendTopOffset + + (Number(yAxisTitleMargin) || 0) + : TIMESERIES_CONSTANTS.gridOffsetTop + + showLegendTopOffset + + yAxisOffset, bottom: zoomable && !isHorizontal ? TIMESERIES_CONSTANTS.gridOffsetBottomZoomable + xAxisOffset
