This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch trigger_ci in repository https://gitbox.apache.org/repos/asf/superset.git
commit f845b9dc967a4f541fac0bbf98cf4f5494471b62 Author: Maxime Beauchemin <[email protected]> AuthorDate: Thu Apr 4 08:53:18 2024 -0700 fix: add more path triggers for python GHAs Recently with https://github.com/apache/superset/pull/27867 (upgrading) pylint, we discovered that many python-related checks that should have run didn't run. In this PR I look at the python-specific GHAs and their triggers and make sure they are triggered not only when `superset/**` changes, but also when `requirements/**` changes and/or when `tests/` changes. There's more that could be done here, but this is a solid start that will at the very least make sure that the python library bumping triggers the proper CI logic. About keeping these more DRY, I'd love to have a simple mechanism to repeat snippets of code across actions or even within actions, but AFAIK there are not clear/clean way to do this at this time. I've been thinking about bringing `Jinja2` into the mix, but I think it's a bit of a bazooka to kill a fly at this time. --- .github/workflows/codeql-analysis.yml | 4 ---- .github/workflows/superset-python-integrationtest.yml | 8 ++++++++ .github/workflows/superset-python-misc.yml | 4 ++++ .github/workflows/superset-python-presto-hive.yml | 4 ++++ 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index c200f9cb36..0fc84f0f24 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -3,13 +3,9 @@ name: "CodeQL" on: push: branches: ["master", "[0-9].[0-9]"] - paths: - - "superset/**" pull_request: # The branches below must be a subset of the branches above branches: ["master"] - paths: - - "superset/**" schedule: - cron: "0 4 * * *" diff --git a/.github/workflows/superset-python-integrationtest.yml b/.github/workflows/superset-python-integrationtest.yml index 75eea5c70a..933ee59e22 100644 --- a/.github/workflows/superset-python-integrationtest.yml +++ b/.github/workflows/superset-python-integrationtest.yml @@ -6,8 +6,16 @@ on: branches: - "master" - "[0-9].[0-9]" + paths: + - "superset/**" + - "requirements/**" + - "tests/integration_tests/**" pull_request: types: [synchronize, opened, reopened, ready_for_review] + paths: + - "superset/**" + - "requirements/**" + - "tests/integration_tests/**" concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }} diff --git a/.github/workflows/superset-python-misc.yml b/.github/workflows/superset-python-misc.yml index 8eb34d939a..c65c4e1d62 100644 --- a/.github/workflows/superset-python-misc.yml +++ b/.github/workflows/superset-python-misc.yml @@ -8,10 +8,14 @@ on: - "[0-9].[0-9]" paths: - "superset/**" + - "requirements/**" + - "tests/**" pull_request: types: [synchronize, opened, reopened, ready_for_review] paths: - "superset/**" + - "requirements/**" + - "tests/**" # cancel previous workflow jobs for PRs concurrency: diff --git a/.github/workflows/superset-python-presto-hive.yml b/.github/workflows/superset-python-presto-hive.yml index dd8d6612aa..bf38261ac3 100644 --- a/.github/workflows/superset-python-presto-hive.yml +++ b/.github/workflows/superset-python-presto-hive.yml @@ -8,10 +8,14 @@ on: - "[0-9].[0-9]" paths: - "superset/**" + - "requirements/**" + - "tests/**" pull_request: types: [synchronize, opened, reopened, ready_for_review] paths: - "superset/**" + - "requirements/**" + - "tests/**" # cancel previous workflow jobs for PRs concurrency:
