This is an automated email from the ASF dual-hosted git repository. lilykuang pushed a commit to branch table-time-comparison-blank in repository https://gitbox.apache.org/repos/asf/superset.git
commit 6edf76bb9484130ccb7e8b4ad672c18d496368a4 Author: lilykuang <[email protected]> AuthorDate: Thu Apr 4 17:00:35 2024 -0700 fix: table with time comparison shows blank columns when dimension is numeric --- superset-frontend/plugins/plugin-chart-table/src/transformProps.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts b/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts index a49c3ac4af..af0e4cdde6 100644 --- a/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts +++ b/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts @@ -288,7 +288,11 @@ const processComparisonColumns = ( const config = columnConfig[col.key] || {}; const savedFormat = columnFormats?.[col.key]; const numberFormat = config.d3NumberFormat || savedFormat; - if (col.isNumeric && !col.key.includes(COMPARISON_PREFIX)) { + if ( + (col.isMetric || col.isPercentMetric) && + !col.key.includes(COMPARISON_PREFIX) && + col.isNumeric + ) { return [ { ...col,
