This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 300669f1e71bc23c498452ba06514f0b1f17785f
Author: Lily Kuang <[email protected]>
AuthorDate: Wed Apr 3 16:05:04 2024 -0700

    fix(bar-chart): change legend padding for horizontal orientation (#27883)
    
    (cherry picked from commit cfa0556df7a6d82257deff7753b82628229c6e8c)
---
 .../plugin-chart-echarts/src/Timeseries/transformers.ts     | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git 
a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts 
b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
index be89fdfc74..f5292aa898 100644
--- 
a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
+++ 
b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
@@ -561,6 +561,11 @@ export function getPadding(
     ? TIMESERIES_CONSTANTS.yAxisLabelTopOffset
     : 0;
   const xAxisOffset = addXAxisTitleOffset ? Number(xAxisTitleMargin) || 0 : 0;
+  const showLegendTopOffset =
+    isHorizontal && showLegend && legendOrientation === LegendOrientation.Top
+      ? 100
+      : 0;
+
   return getChartPadding(
     showLegend,
     legendOrientation,
@@ -568,8 +573,12 @@ export function getPadding(
     {
       top:
         yAxisTitlePosition && yAxisTitlePosition === 'Top'
-          ? TIMESERIES_CONSTANTS.gridOffsetTop + (Number(yAxisTitleMargin) || 
0)
-          : TIMESERIES_CONSTANTS.gridOffsetTop + yAxisOffset,
+          ? TIMESERIES_CONSTANTS.gridOffsetTop +
+            showLegendTopOffset +
+            (Number(yAxisTitleMargin) || 0)
+          : TIMESERIES_CONSTANTS.gridOffsetTop +
+            showLegendTopOffset +
+            yAxisOffset,
       bottom:
         zoomable && !isHorizontal
           ? TIMESERIES_CONSTANTS.gridOffsetBottomZoomable + xAxisOffset

Reply via email to