This is an automated email from the ASF dual-hosted git repository.
lilykuang pushed a commit to branch table-time-comparison
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/table-time-comparison by this
push:
new dc5828ede4 fix: table with time comparison shows blank data when
dimension is numeric (#27909)
dc5828ede4 is described below
commit dc5828ede4557f612a85ae09aa8aeee23dd8558a
Author: Lily Kuang <[email protected]>
AuthorDate: Tue Apr 9 09:58:29 2024 -0700
fix: table with time comparison shows blank data when dimension is numeric
(#27909)
---
superset-frontend/plugins/plugin-chart-table/src/transformProps.ts | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
b/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
index a49c3ac4af..af0e4cdde6 100644
--- a/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
+++ b/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
@@ -288,7 +288,11 @@ const processComparisonColumns = (
const config = columnConfig[col.key] || {};
const savedFormat = columnFormats?.[col.key];
const numberFormat = config.d3NumberFormat || savedFormat;
- if (col.isNumeric && !col.key.includes(COMPARISON_PREFIX)) {
+ if (
+ (col.isMetric || col.isPercentMetric) &&
+ !col.key.includes(COMPARISON_PREFIX) &&
+ col.isNumeric
+ ) {
return [
{
...col,
