This is an automated email from the ASF dual-hosted git repository. diegopucci pushed a commit to branch geido/fix/accessibility-form-labels in repository https://gitbox.apache.org/repos/asf/superset.git
commit 006dc3ec4785f2f78ef4c93b52ef81089bcede2d Author: Diego Pucci <[email protected]> AuthorDate: Wed Apr 10 10:20:03 2024 +0200 Add aria-label to forms --- superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx | 1 + .../components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx | 1 + 2 files changed, 2 insertions(+) diff --git a/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx b/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx index 840020cad8..ed2d9319c5 100644 --- a/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx +++ b/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx @@ -168,6 +168,7 @@ function SearchInput({ count, value, onChange }: SearchInputProps) { className="form-control input-sm" placeholder={tn('search.num_records', count)} value={value} + aria-label={t('Search %s records', count)} onChange={onChange} /> </span> diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx index bc66d07c08..b9229153b8 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx @@ -315,6 +315,7 @@ const FilterControl = ({ <div> <FormItem label={label} + aria-label={name} required={filter?.controlValues?.enableEmptyFilter} validateStatus={validateStatus} >
