(superset) branch master updated: chore(superset-ui-core and NoResultsComponent): Migrate to RTL, add RTL modules to the ui-core (#28187)

[diegopucci]

This is an automated email from the ASF dual-hosted git repository.

diegopucci pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 601896b1fc chore(superset-ui-core and NoResultsComponent): Migrate to 
RTL, add RTL modules to the ui-core (#28187)
601896b1fc is described below

commit 601896b1fc8bf77bffc7e04a9e477873912b7195
Author: Ross Mabbett <92495987+rtex...@users.noreply.github.com>
AuthorDate: Tue Apr 30 09:10:35 2024 -0400

    chore(superset-ui-core and NoResultsComponent): Migrate to RTL, add RTL 
modules to the ui-core (#28187)
---
 .../packages/superset-ui-core/package.json         |  4 ++++
 .../chart/components/NoResultsComponent.test.tsx   | 27 ++++++++++++++--------
 2 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/superset-frontend/packages/superset-ui-core/package.json 
b/superset-frontend/packages/superset-ui-core/package.json
index 7ccad2a2df..1a26e0f49d 100644
--- a/superset-frontend/packages/superset-ui-core/package.json
+++ b/superset-frontend/packages/superset-ui-core/package.json
@@ -73,6 +73,10 @@
     "@emotion/cache": "^11.4.0",
     "@emotion/react": "^11.4.1",
     "@emotion/styled": "^11.3.0",
+    "@testing-library/dom": "^7.29.4",
+    "@testing-library/jest-dom": "^5.11.6",
+    "@testing-library/react": "^11.2.0",
+    "@testing-library/user-event": "^12.7.0",
     "@types/react": "*",
     "@types/react-loadable": "*",
     "@types/tinycolor2": "*",
diff --git 
a/superset-frontend/packages/superset-ui-core/test/chart/components/NoResultsComponent.test.tsx
 
b/superset-frontend/packages/superset-ui-core/test/chart/components/NoResultsComponent.test.tsx
index 333a0cb875..fa4a3787f4 100644
--- 
a/superset-frontend/packages/superset-ui-core/test/chart/components/NoResultsComponent.test.tsx
+++ 
b/superset-frontend/packages/superset-ui-core/test/chart/components/NoResultsComponent.test.tsx
@@ -18,18 +18,25 @@
  */
 
 import React from 'react';
-import { shallow } from 'enzyme';
-import { configure } from '@superset-ui/core';
+import { render, screen } from '@testing-library/react';
+import '@testing-library/jest-dom';
+import { ThemeProvider, supersetTheme } from '../../../src/style';
 import NoResultsComponent from 
'../../../src/chart/components/NoResultsComponent';
 
-configure();
+const renderNoResultsComponent = () =>
+  render(
+    <ThemeProvider theme={supersetTheme}>
+      <NoResultsComponent height="400" width="300" />
+    </ThemeProvider>,
+  );
 
-describe('NoResultsComponent', () => {
-  it('renders the no results error', () => {
-    const wrapper = shallow(<NoResultsComponent height="400" width="300" />);
+test('renders the no results error', () => {
+  renderNoResultsComponent();
 
-    expect(wrapper.text()).toEqual(
-      'No ResultsNo results were returned for this query. If you expected 
results to be returned, ensure any filters are configured properly and the 
datasource contains data for the selected time range.',
-    );
-  });
+  expect(screen.getByText(/No Results/)).toBeInTheDocument();
+  expect(
+    screen.getByText(
+      'No results were returned for this query. If you expected results to be 
returned, ensure any filters are configured properly and the datasource 
contains data for the selected time range.',
+    ),
+  ).toBeInTheDocument();
 });