This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch codecod_ref in repository https://gitbox.apache.org/repos/asf/superset.git
commit fddda37483527a5e95ce837d6d8c705ed1f63055 Author: Maxime Beauchemin <[email protected]> AuthorDate: Tue Apr 30 13:42:11 2024 -0700 chore: allow codecov to detect SHA In our CI, where codecov.sh is called, there's a message from its CLI saying `Issue detecting commit SHA. Please run actions/checkout with fetch-depth > 1 or set to 0`. From my understanding setting depth=2 should allow to resolve this, without having much impact on cloning workload. --- .github/workflows/superset-frontend.yml | 4 +--- .github/workflows/superset-python-integrationtest.yml | 1 + .github/workflows/superset-python-presto-hive.yml | 1 + .github/workflows/superset-python-unittest.yml | 1 + 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/superset-frontend.yml b/.github/workflows/superset-frontend.yml index fe373a7c05..04ace66fb5 100644 --- a/.github/workflows/superset-frontend.yml +++ b/.github/workflows/superset-frontend.yml @@ -20,7 +20,7 @@ jobs: - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )" uses: actions/checkout@v4 with: - fetch-depth: 0 # Fetch all history + fetch-depth: 2 # codecov needs 2 to get a read on the SHA persist-credentials: false submodules: recursive - name: Check npm lock file version @@ -82,5 +82,3 @@ jobs: if: steps.check.outputs.frontend working-directory: ./superset-frontend run: ../.github/workflows/codecov.sh -c -F javascript - env: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} diff --git a/.github/workflows/superset-python-integrationtest.yml b/.github/workflows/superset-python-integrationtest.yml index 8005e05595..2f36e37fab 100644 --- a/.github/workflows/superset-python-integrationtest.yml +++ b/.github/workflows/superset-python-integrationtest.yml @@ -148,6 +148,7 @@ jobs: with: persist-credentials: false submodules: recursive + fetch-depth: 2 # codecov needs 2 to get a read on the SHA - name: Check for file changes id: check uses: ./.github/actions/change-detector/ diff --git a/.github/workflows/superset-python-presto-hive.yml b/.github/workflows/superset-python-presto-hive.yml index cf3e506bb9..8ec86f34fb 100644 --- a/.github/workflows/superset-python-presto-hive.yml +++ b/.github/workflows/superset-python-presto-hive.yml @@ -52,6 +52,7 @@ jobs: with: persist-credentials: false submodules: recursive + fetch-depth: 2 # codecov needs 2 to get a read on the SHA - name: Check for file changes id: check uses: ./.github/actions/change-detector/ diff --git a/.github/workflows/superset-python-unittest.yml b/.github/workflows/superset-python-unittest.yml index cf3e7c7641..7261f2667e 100644 --- a/.github/workflows/superset-python-unittest.yml +++ b/.github/workflows/superset-python-unittest.yml @@ -28,6 +28,7 @@ jobs: with: persist-credentials: false submodules: recursive + fetch-depth: 2 # codecov needs 2 to get a read on the SHA - name: Check for file changes id: check uses: ./.github/actions/change-detector/
