This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch action_validator
in repository https://gitbox.apache.org/repos/asf/superset.git

commit d4a4cb6882a4b3adf9c07a04fa5d0ab0b159dd1a
Author: Maxime Beauchemin <[email protected]>
AuthorDate: Mon May 6 09:05:11 2024 -0700

    chore: add action-validator as pre-commit hook
    
    https://github.com/apache/superset/pull/28343 fixes an issue where I had 
broken a specific github action workflow in a previous PR without realizing I 
did. If/when altering the yaml, if the yaml itsefl is valid (we have a check 
for that) yet the schema is not - either through passing the right data 
structure or required types, the action just won't run and the PR is still 
mergeable. The failure gets somewhat burried on the Actions tab (at the bottom 
of https://github.com/apache/supers [...]
    
    Here I'm hoping that this pre-commit hook will both catch this early, and 
prevent the PR from being mergeable.
    
    Find out more about the hook here: 
https://github.com/mpalmer/action-validator
---
 .pre-commit-config.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 236ea811b3..d2e0956792 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -91,3 +91,7 @@ repos:
             "-sn", # Don't display the score
             "--rcfile=.pylintrc",
           ]
+  - repo: https://github.com/mpalmer/action-validator
+    rev: v0.5.1
+    hooks:
+      - id: action-validator

Reply via email to