This is an automated email from the ASF dual-hosted git repository. michaelsmolina pushed a commit to branch 4.0 in repository https://gitbox.apache.org/repos/asf/superset.git
commit 13a11c254639ea21880425e7b92cd1e98275d8e7 Author: John Bodley <[email protected]> AuthorDate: Fri Jun 14 09:38:36 2024 -0700 fix(sqllab): Do not strip comments when executing SQL statements (#29248) (cherry picked from commit b50e3af07c7204eb73d5837a64dbf03ee6a5c7f0) --- superset/sqllab/query_render.py | 1 - tests/integration_tests/sqllab_tests.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/superset/sqllab/query_render.py b/superset/sqllab/query_render.py index caf9a3cb2b..67bea2b1fb 100644 --- a/superset/sqllab/query_render.py +++ b/superset/sqllab/query_render.py @@ -60,7 +60,6 @@ class SqlQueryRenderImpl(SqlQueryRender): parsed_query = ParsedQuery( query_model.sql, - strip_comments=True, engine=query_model.database.db_engine_spec.engine, ) rendered_query = sql_template_processor.process_template( diff --git a/tests/integration_tests/sqllab_tests.py b/tests/integration_tests/sqllab_tests.py index 5248aab2eb..b13eccdd90 100644 --- a/tests/integration_tests/sqllab_tests.py +++ b/tests/integration_tests/sqllab_tests.py @@ -571,9 +571,9 @@ class TestSqlLab(SupersetTestCase): assert data["status"] == "success" data = self.run_sql( - "SELECT * FROM birth_names WHERE state = '{{ state }}' -- blabblah {{ extra1 }} {{fake.fn()}}\nLIMIT 10", + "SELECT * FROM birth_names WHERE state = '{{ state }}' -- blabblah {{ extra1 }}\nLIMIT 10", "3", - template_params=json.dumps({"state": "CA"}), + template_params=json.dumps({"state": "CA", "extra1": "comment"}), ) assert data["status"] == "success"
