This is an automated email from the ASF dual-hosted git repository.
sfirke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 08145d88b9 style(explore): clarify ambiguously named "sort by" field
(#30254)
08145d88b9 is described below
commit 08145d88b95d37c034fc939ddbc37d1bab727e5e
Author: Sam Firke <[email protected]>
AuthorDate: Wed Sep 18 15:18:42 2024 -0400
style(explore): clarify ambiguously named "sort by" field (#30254)
---
.../superset-ui-chart-controls/src/shared-controls/dndControls.tsx | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx
b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx
index 96124d6c67..130478893e 100644
---
a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx
+++
b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx
@@ -188,11 +188,12 @@ export const dndSortByControl: SharedControlConfig<
'DndMetricSelect' | 'MetricsControl'
> = {
type: 'DndMetricSelect',
- label: t('Sort by'),
+ label: t('Sort query by'),
default: null,
description: t(
- 'This metric is used to define row selection criteria (how the rows are
sorted) if a series or row limit is present. ' +
- 'If not defined, it reverts to the first metric (where appropriate).',
+ 'Orders the query result that generates the source data for this chart. ' +
+ 'If a series or row limit is reached, this determines what data are
truncated. ' +
+ 'If undefined, defaults to the first metric (where appropriate).',
),
mapStateToProps: ({ datasource }) => ({
columns: datasource?.columns || [],
