This is an automated email from the ASF dual-hosted git repository.
diegopucci pushed a commit to branch geido/fix/filters-applicability
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to
refs/heads/geido/fix/filters-applicability by this push:
new 8de9cd6048 chore(Todo): Remove todo comment
8de9cd6048 is described below
commit 8de9cd60489d1ebe2872ccc8c9412ae4050e1e8f
Author: Diego Pucci <[email protected]>
AuthorDate: Thu Oct 10 20:31:20 2024 +0300
chore(Todo): Remove todo comment
---
superset-frontend/src/dashboard/components/Dashboard.jsx | 3 ---
1 file changed, 3 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/Dashboard.jsx
b/superset-frontend/src/dashboard/components/Dashboard.jsx
index f527f7fe6c..1953889c5d 100644
--- a/superset-frontend/src/dashboard/components/Dashboard.jsx
+++ b/superset-frontend/src/dashboard/components/Dashboard.jsx
@@ -219,9 +219,6 @@ class Dashboard extends PureComponent {
const currFilterKeys = Object.keys(activeFilters);
const appliedFilterKeys = Object.keys(appliedFilters);
- // TODO: @geido
- // when removing a filter from the scope of an already applied filter,
must refresh query, check if master issue
-
const allKeys = new Set(currFilterKeys.concat(appliedFilterKeys));
const affectedChartIds = getAffectedOwnDataCharts(
ownDataCharts,
