This is an automated email from the ASF dual-hosted git repository. diegopucci pushed a commit to branch geido/feat/progressive-dashboard-header in repository https://gitbox.apache.org/repos/asf/superset.git
commit 3cb3c8b2352abd9442225ca2b8e73772ba64d100 Author: Diego Pucci <[email protected]> AuthorDate: Tue Oct 15 17:09:19 2024 +0300 chore(Fave): Set Fave to default false --- superset-frontend/src/components/FaveStar/index.tsx | 2 +- superset-frontend/src/dashboard/components/Header/index.jsx | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/superset-frontend/src/components/FaveStar/index.tsx b/superset-frontend/src/components/FaveStar/index.tsx index 49c7a71cd0..fa7963480c 100644 --- a/superset-frontend/src/components/FaveStar/index.tsx +++ b/superset-frontend/src/components/FaveStar/index.tsx @@ -41,7 +41,7 @@ const StyledLink = styled.a` const FaveStar = ({ itemId, - isStarred, + isStarred = false, showTooltip, saveFaveStar, fetchFaveStar, diff --git a/superset-frontend/src/dashboard/components/Header/index.jsx b/superset-frontend/src/dashboard/components/Header/index.jsx index 4aa92567a9..a69c152fdd 100644 --- a/superset-frontend/src/dashboard/components/Header/index.jsx +++ b/superset-frontend/src/dashboard/components/Header/index.jsx @@ -390,7 +390,7 @@ class Header extends PureComponent { roles: dashboardInfo.roles, slug, metadata: { - ...dashboardInfo?.metadata, + ...dashboardInfo.metadata, color_namespace: currentColorNamespace, color_scheme: currentColorScheme, positions, @@ -712,7 +712,7 @@ class Header extends PureComponent { logEvent={logEvent} /> } - showFaveStar={user?.userId && dashboardInfo?.id} + showFaveStar={user?.userId} showTitlePanelItems /> {this.state.showingPropertiesModal && (
