This is an automated email from the ASF dual-hosted git repository.
sophieyou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 3ec3f0a610 fix(explore): Update tooltip copy for rendering html in
tables and pivot tables (#30682)
3ec3f0a610 is described below
commit 3ec3f0a610807a6da4421fd5c0fb815bf3d023f3
Author: yousoph <[email protected]>
AuthorDate: Fri Nov 1 10:54:50 2024 -0700
fix(explore): Update tooltip copy for rendering html in tables and pivot
tables (#30682)
Co-authored-by: Joe Li <[email protected]>
---
.../src/plugin/controlPanel.tsx | 18 +++++++-----
.../plugin-chart-table/src/controlPanel.tsx | 34 ++++++++++++----------
2 files changed, 28 insertions(+), 24 deletions(-)
diff --git
a/superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx
b/superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx
index e5dea8c468..cda65f5527 100644
---
a/superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx
+++
b/superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx
@@ -16,6 +16,13 @@
* specific language governing permissions and limitations
* under the License.
*/
+import {
+ ControlPanelConfig,
+ D3_TIME_FORMAT_OPTIONS,
+ Dataset,
+ getStandardizedControls,
+ sharedControls,
+} from '@superset-ui/chart-controls';
import {
ensureIsArray,
isAdhocColumn,
@@ -25,13 +32,6 @@ import {
t,
validateNonEmpty,
} from '@superset-ui/core';
-import {
- ControlPanelConfig,
- D3_TIME_FORMAT_OPTIONS,
- sharedControls,
- Dataset,
- getStandardizedControls,
-} from '@superset-ui/chart-controls';
import { MetricsLayoutEnum } from '../types';
const config: ControlPanelConfig = {
@@ -436,7 +436,9 @@ const config: ControlPanelConfig = {
label: t('Render columns in HTML format'),
renderTrigger: true,
default: true,
- description: t('Render data in HTML format if applicable.'),
+ description: t(
+ 'Renders table cells as HTML when applicable. For example,
HTML <a> tags will be rendered as hyperlinks.',
+ ),
},
},
],
diff --git a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
index 0d27c73c48..e67bdfcea0 100644
--- a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
+++ b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
@@ -18,32 +18,32 @@
* under the License.
*/
import {
- ensureIsArray,
- GenericDataType,
- isAdhocColumn,
- isPhysicalColumn,
- QueryFormColumn,
- QueryMode,
- SMART_DATE_ID,
- t,
-} from '@superset-ui/core';
-import {
+ ColumnMeta,
ColumnOption,
ControlConfig,
ControlPanelConfig,
ControlPanelsContainerProps,
- ControlStateMapping,
- D3_TIME_FORMAT_OPTIONS,
- QueryModeLabel,
- sharedControls,
ControlPanelState,
ControlState,
+ ControlStateMapping,
+ D3_TIME_FORMAT_OPTIONS,
Dataset,
- ColumnMeta,
defineSavedMetrics,
getStandardizedControls,
+ QueryModeLabel,
sections,
+ sharedControls,
} from '@superset-ui/chart-controls';
+import {
+ ensureIsArray,
+ GenericDataType,
+ isAdhocColumn,
+ isPhysicalColumn,
+ QueryFormColumn,
+ QueryMode,
+ SMART_DATE_ID,
+ t,
+} from '@superset-ui/core';
import { isEmpty } from 'lodash';
import { PAGE_SIZE_OPTIONS } from './consts';
@@ -466,7 +466,9 @@ const config: ControlPanelConfig = {
label: t('Render columns in HTML format'),
renderTrigger: true,
default: true,
- description: t('Render data in HTML format if applicable.'),
+ description: t(
+ 'Renders table cells as HTML when applicable. For example,
HTML <a> tags will be rendered as hyperlinks.',
+ ),
},
},
],