(superset) branch filters-modal-layout-cleanup updated: css layout switching rather than react.

[rusackas]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch filters-modal-layout-cleanup
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/filters-modal-layout-cleanup 
by this push:
     new 6b8583ec6a css layout switching rather than react.
6b8583ec6a is described below

commit 6b8583ec6acca07e6bf576a14c61a7239b057f5a
Author: Evan Rusackas <e...@rusackas.com>
AuthorDate: Fri Dec 13 15:09:56 2024 -0700

    css layout switching rather than react.
---
 .../FiltersConfigModal/FiltersConfigModal.tsx      | 61 ++++++++++++----------
 1 file changed, 32 insertions(+), 29 deletions(-)

diff --git 
a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
 
b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
index 0575020b28..7909a0a2cf 100644
--- 
a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
+++ 
b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
@@ -635,35 +635,38 @@ function FiltersConfigModal({
         const isDivider = id.startsWith(NATIVE_FILTER_DIVIDER_PREFIX);
         const isActive = currentFilterId === id;
         return (
-          isActive && (
-            <>
-              {isDivider ? (
-                <DividerConfigForm
-                  componentId={id}
-                  divider={filterConfigMap[id] as Divider}
-                />
-              ) : (
-                <FiltersConfigForm
-                  expanded={expanded}
-                  ref={configFormRef}
-                  form={form}
-                  filterId={id}
-                  filterToEdit={filterConfigMap[id] as Filter}
-                  removedFilters={removedFilters}
-                  restoreFilter={restoreFilter}
-                  getAvailableFilters={getAvailableFilters}
-                  key={id}
-                  activeFilterPanelKeys={activeFilterPanelKey}
-                  handleActiveFilterPanelChange={handleActiveFilterPanelChange}
-                  isActive={isActive}
-                  setErroredFilters={setErroredFilters}
-                  validateDependencies={validateDependencies}
-                  getDependencySuggestion={getDependencySuggestion}
-                  onModifyFilter={handleModifyFilter}
-                />
-              )}
-            </>
-          )
+          <div
+            style={{
+              display: isActive ? '' : 'none',
+              height: '100%',
+            }}
+          >
+            {isDivider ? (
+              <DividerConfigForm
+                componentId={id}
+                divider={filterConfigMap[id] as Divider}
+              />
+            ) : (
+              <FiltersConfigForm
+                expanded={expanded}
+                ref={configFormRef}
+                form={form}
+                filterId={id}
+                filterToEdit={filterConfigMap[id] as Filter}
+                removedFilters={removedFilters}
+                restoreFilter={restoreFilter}
+                getAvailableFilters={getAvailableFilters}
+                key={id}
+                activeFilterPanelKeys={activeFilterPanelKey}
+                handleActiveFilterPanelChange={handleActiveFilterPanelChange}
+                isActive={isActive}
+                setErroredFilters={setErroredFilters}
+                validateDependencies={validateDependencies}
+                getDependencySuggestion={getDependencySuggestion}
+                onModifyFilter={handleModifyFilter}
+              />
+            )}
+          </div>
         );
       }),
     [