(superset) branch better-filter-options-targets updated: fix(filter options): full size list item targets

[rusackas]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch better-filter-options-targets
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/better-filter-options-targets 
by this push:
     new 83a599ff27 fix(filter options): full size list item targets
83a599ff27 is described below

commit 83a599ff2753dd0b26cd37ccc8d8fb63449f7380
Author: Evan Rusackas <e...@rusackas.com>
AuthorDate: Fri Dec 13 16:10:37 2024 -0700

    fix(filter options): full size list item targets
---
 .../src/components/DropdownSelectableIcon/index.tsx              | 7 ++++---
 .../nativeFilters/FilterBar/FilterConfigurationLink/index.tsx    | 9 ++++++---
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/superset-frontend/src/components/DropdownSelectableIcon/index.tsx 
b/superset-frontend/src/components/DropdownSelectableIcon/index.tsx
index a1b755dcf2..12d23dc242 100644
--- a/superset-frontend/src/components/DropdownSelectableIcon/index.tsx
+++ b/superset-frontend/src/components/DropdownSelectableIcon/index.tsx
@@ -90,8 +90,9 @@ const StyleMenuItem = styled(Menu.Item)<{ divider?: boolean 
}>`
 const StyleSubmenuItem = styled.div`
   display: flex;
   justify-content: space-between;
-  > span {
-    width: 100%;
+  width: 100%;
+  > div {
+    flex-grow: 1;
   }
 `;
 
@@ -102,7 +103,7 @@ export default (props: DropDownSelectableProps) => {
     () => (label: string | ReactNode, key: string, divider?: boolean) => (
       <StyleMenuItem key={key} divider={divider}>
         <StyleSubmenuItem>
-          <span>{label}</span>
+          {label}
           {selectedKeys?.includes(key) && (
             <Icons.Check
               iconColor={theme.colors.primary.base}
diff --git 
a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx
 
b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx
index f8164d241a..7ab574ed7d 100644
--- 
a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx
+++ 
b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx
@@ -62,10 +62,13 @@ export const FilterConfigurationLink: FC<FCBProps> = ({
 
   return (
     <>
-      {/* eslint-disable-next-line jsx-a11y/no-static-element-interactions */}
-      <span {...getFilterBarTestId('create-filter')} onClick={handleClick}>
+      <div
+        {...getFilterBarTestId('create-filter')}
+        onClick={handleClick}
+        role="button"
+      >
         {children}
-      </span>
+      </div>
       <FiltersConfigModal
         isOpen={isOpen}
         onSave={submit}