This is an automated email from the ASF dual-hosted git repository. diegopucci pushed a commit to branch geido/fix/cypress-flakiness in repository https://gitbox.apache.org/repos/asf/superset.git
commit 266d5e7dcf6ecaaf96044961b1a7b3bb8aa907ef Author: Diego Pucci <[email protected]> AuthorDate: Wed Jan 22 13:08:01 2025 +0100 fix(E2E): Battling against Cypress flakiness --- .../cypress-base/cypress/e2e/dashboard_list/list.test.ts | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/superset-frontend/cypress-base/cypress/e2e/dashboard_list/list.test.ts b/superset-frontend/cypress-base/cypress/e2e/dashboard_list/list.test.ts index 77d0953edb..cde72d26c5 100644 --- a/superset-frontend/cypress-base/cypress/e2e/dashboard_list/list.test.ts +++ b/superset-frontend/cypress-base/cypress/e2e/dashboard_list/list.test.ts @@ -142,7 +142,7 @@ describe('Dashboards list', () => { }); }); - describe('common actions', () => { + describe.only('common actions', () => { beforeEach(() => { cy.createSampleDashboards([0, 1, 2, 3]); cy.visit(DASHBOARD_LIST); @@ -213,8 +213,8 @@ describe('Dashboards list', () => { cy.getBySel('table-row') .eq(0) .contains('4 - Sample dashboard') - .should('exist'); - cy.getBySel('dashboard-list-trash-icon').eq(0).click(); + .should('be.visible'); + cy.getBySel('dashboard-list-trash-icon').eq(0).should('exist').click(); confirmDelete(); cy.getBySel('table-row') .eq(0) @@ -229,9 +229,11 @@ describe('Dashboards list', () => { cy.getBySel('styled-card') .eq(0) .contains('1 - Sample dashboard') - .should('exist'); + .should('be.visible'); openMenu(); - cy.getBySel('dashboard-card-option-delete-button').click(); + cy.getBySel('dashboard-card-option-delete-button') + .should('be.visible') + .click(); confirmDelete(); cy.getBySel('styled-card') .eq(0)
