This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch prettier_first in repository https://gitbox.apache.org/repos/asf/superset.git
commit 2b5c40e58dd8ee58785b21739e8c3b38703ed23d Author: Maxime Beauchemin <[email protected]> AuthorDate: Fri Jan 24 11:06:13 2025 -0800 feat: run prettier before eslint in pre-commit hooks Simply changing the ordering here as prettier is set to mutate/fix things, and eslint simply logs and errors out, often duplicating messaging on a single issues. Running prettier first makes more sense here. --- .pre-commit-config.yaml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index bb34ee4055..a40c26f218 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -52,14 +52,6 @@ repos: - id: trailing-whitespace exclude: ^.*\.(snap) args: ["--markdown-linebreak-ext=md"] - - repo: local - hooks: - - id: eslint - name: eslint - entry: bash -c 'cd superset-frontend && npm run eslint -- $(echo "$@" | sed "s|superset-frontend/||g")' - language: system - pass_filenames: true - files: \.(js|jsx|ts|tsx)$ - repo: https://github.com/pre-commit/mirrors-prettier rev: v4.0.0-alpha.8 # Use the sha or tag you want to point at hooks: @@ -68,6 +60,14 @@ repos: - [email protected] args: ["--ignore-path=./superset-frontend/.prettierignore"] files: "superset-frontend" + - repo: local + hooks: + - id: eslint + name: eslint + entry: bash -c 'cd superset-frontend && npm run eslint -- $(echo "$@" | sed "s|superset-frontend/||g")' + language: system + pass_filenames: true + files: \.(js|jsx|ts|tsx)$ # blacklist unsafe functions like make_url (see #19526) - repo: https://github.com/skorokithakis/blacklist-pre-commit-hook rev: e2f070289d8eddcaec0b580d3bde29437e7c8221
