This is an automated email from the ASF dual-hosted git repository. enzomartellucci pushed a commit to branch refactor/antd5-radio in repository https://gitbox.apache.org/repos/asf/superset.git
commit 64a2a3c723c66697da4b98d456565ff52e600060 Author: Enzo Martellucci <[email protected]> AuthorDate: Sat Jan 25 18:41:55 2025 +0100 refactor(CurrentCalendarFrame): Implements Radio from Antd5 --- .../controls/DateFilterControl/DateFilterLabel.tsx | 6 ------ .../components/CurrentCalendarFrame.tsx | 18 +++++------------- 2 files changed, 5 insertions(+), 19 deletions(-) diff --git a/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx b/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx index a4b0ca3a3e..dc4057f33b 100644 --- a/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx +++ b/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx @@ -87,12 +87,6 @@ const ContentStyleWrapper = styled.div` margin: 8px 0; } - .vertical-radio { - display: block; - height: 40px; - line-height: 40px; - } - .section-title { font-style: normal; font-weight: ${theme.typography.weights.bold}; diff --git a/superset-frontend/src/explore/components/controls/DateFilterControl/components/CurrentCalendarFrame.tsx b/superset-frontend/src/explore/components/controls/DateFilterControl/components/CurrentCalendarFrame.tsx index 7d1a3a7b78..4f1babfd5a 100644 --- a/superset-frontend/src/explore/components/controls/DateFilterControl/components/CurrentCalendarFrame.tsx +++ b/superset-frontend/src/explore/components/controls/DateFilterControl/components/CurrentCalendarFrame.tsx @@ -41,25 +41,17 @@ export function CurrentCalendarFrame({ onChange, value }: FrameComponentProps) { <div className="section-title"> {t('Configure Time Range: Current...')} </div> - <Radio.Group + <Radio.VerticalGroup + size='large' value={value} onChange={(e: any) => { let newValue = e.target.value; - // Sanitization: Trim whitespace newValue = newValue.trim(); - // Validation: Check if the value is non-empty - if (newValue === '') { - return; - } + if (newValue === '') return; onChange(newValue); }} - > - {CURRENT_RANGE_OPTIONS.map(({ value, label }) => ( - <Radio key={value} value={value} className="vertical-radio"> - {label} - </Radio> - ))} - </Radio.Group> + options={CURRENT_RANGE_OPTIONS} + /> </> ); }
