This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch reenable-cypress-checks in repository https://gitbox.apache.org/repos/asf/superset.git
commit 3ea7aacf070852d1d3eb7e86abbd7e72e76b2497 Author: Maxime Beauchemin <[email protected]> AuthorDate: Mon Jan 27 21:31:09 2025 -0800 fix: re-enable cypress checks I got a bit confused and reckless on https://github.com/apache/superset/pull/31858, when I disabled many cypress tests, many of which are or may be flaky at times, but in this instance were probably triggered by some real issues in that PR. Renabling them all and will monitor PRs and master merges to re-disable the ones flaking as needed --- .gitignore | 1 + .../cypress-base/cypress/e2e/dashboard/drillby.test.ts | 2 +- .../cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts | 8 ++++---- .../cypress/e2e/dashboard/horizontalFilterBar.test.ts | 6 +++--- superset-frontend/cypress-base/cypress/e2e/sqllab/query.test.ts | 2 +- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/.gitignore b/.gitignore index 2652502a02..1cc146b53c 100644 --- a/.gitignore +++ b/.gitignore @@ -21,6 +21,7 @@ *.swp __pycache__ +.aider.* .local .cache .bento* diff --git a/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts b/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts index e471d1da8c..c4c5ed4766 100644 --- a/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts +++ b/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts @@ -599,7 +599,7 @@ describe('Drill by modal', () => { ]); }); - it.skip('Radar Chart', () => { + it('Radar Chart', () => { testEchart('radar', 'Radar Chart', [ [182, 49], [423, 91], diff --git a/superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts b/superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts index 4ebd64dd6e..f11aac4454 100644 --- a/superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts +++ b/superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts @@ -335,7 +335,7 @@ describe('Drill to detail modal', () => { }); }); - describe.skip('Bar Chart', () => { + describe('Bar Chart', () => { it('opens the modal with the correct filters', () => { interceptSamples(); @@ -373,7 +373,7 @@ describe('Drill to detail modal', () => { }); }); - describe.skip('Area Chart', () => { + describe('Area Chart', () => { it('opens the modal with the correct filters', () => { testTimeChart('echarts_area'); }); @@ -407,7 +407,7 @@ describe('Drill to detail modal', () => { }); }); - describe.skip('World Map', () => { + describe('World Map', () => { it('opens the modal with the correct filters', () => { interceptSamples(); @@ -567,7 +567,7 @@ describe('Drill to detail modal', () => { }); }); - describe.skip('Radar Chart', () => { + describe('Radar Chart', () => { it('opens the modal with the correct filters', () => { interceptSamples(); diff --git a/superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts b/superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts index bcacae8a36..f1bfa9617e 100644 --- a/superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts +++ b/superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts @@ -176,7 +176,7 @@ describe('Horizontal FilterBar', () => { validateFilterNameOnDashboard(testItems.topTenChart.filterColumn); }); - it.skip('should spot changes in "more filters" and apply their values', () => { + it('should spot changes in "more filters" and apply their values', () => { cy.intercept(`/api/v1/chart/data?form_data=**`).as('chart'); prepareDashboardFilters([ { name: 'test_1', column: 'country_name', datasetId: 2 }, @@ -204,7 +204,7 @@ describe('Horizontal FilterBar', () => { ); }); - it.skip('should focus filter and open "more filters" programmatically', () => { + it('should focus filter and open "more filters" programmatically', () => { prepareDashboardFilters([ { name: 'test_1', column: 'country_name', datasetId: 2 }, { name: 'test_2', column: 'country_code', datasetId: 2 }, @@ -231,7 +231,7 @@ describe('Horizontal FilterBar', () => { cy.get('.ant-select-focused').should('be.visible'); }); - it.skip('should show tag count and one plain tag on focus and only count on blur in select ', () => { + it('should show tag count and one plain tag on focus and only count on blur in select ', () => { prepareDashboardFilters([ { name: 'test_1', column: 'country_name', datasetId: 2 }, ]); diff --git a/superset-frontend/cypress-base/cypress/e2e/sqllab/query.test.ts b/superset-frontend/cypress-base/cypress/e2e/sqllab/query.test.ts index 4f0d0bb8cd..8244043b1c 100644 --- a/superset-frontend/cypress-base/cypress/e2e/sqllab/query.test.ts +++ b/superset-frontend/cypress-base/cypress/e2e/sqllab/query.test.ts @@ -28,7 +28,7 @@ describe('SqlLab query panel', () => { cy.visit('/sqllab'); }); - it.skip('supports entering and running a query', () => { + it('supports entering and running a query', () => { // row limit has to be < ~10 for us to be able to determine how many rows // are fetched below (because React _Virtualized_ does not render all rows) let clockTime = 0;
