This is an automated email from the ASF dual-hosted git repository.
kgabryje pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new a87a13c3ab fix: Filters badge disappeared (#32025)
a87a13c3ab is described below
commit a87a13c3abeb162b70e7f4db807f5ea223346f41
Author: Kamil Gabryjelski <[email protected]>
AuthorDate: Wed Jan 29 14:29:45 2025 +0100
fix: Filters badge disappeared (#32025)
---
.../src/dashboard/components/FiltersBadge/index.tsx | 16 ++++++++--------
superset-frontend/src/explore/types.ts | 2 +-
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/FiltersBadge/index.tsx
b/superset-frontend/src/dashboard/components/FiltersBadge/index.tsx
index 1db359dfbf..57413ffd23 100644
--- a/superset-frontend/src/dashboard/components/FiltersBadge/index.tsx
+++ b/superset-frontend/src/dashboard/components/FiltersBadge/index.tsx
@@ -175,10 +175,10 @@ export const FiltersBadge = ({ chartId }:
FiltersBadgeProps) => {
setDashboardIndicators(indicatorsInitialState);
} else if (prevChartStatus !== 'success') {
if (
- chart?.queriesResponse?.rejected_filters !==
- prevChart?.queriesResponse?.rejected_filters ||
- chart?.queriesResponse?.applied_filters !==
- prevChart?.queriesResponse?.applied_filters ||
+ chart?.queriesResponse?.[0]?.rejected_filters !==
+ prevChart?.queriesResponse?.[0]?.rejected_filters ||
+ chart?.queriesResponse?.[0]?.applied_filters !==
+ prevChart?.queriesResponse?.[0]?.applied_filters ||
dashboardFilters !== prevDashboardFilters ||
datasources !== prevDatasources
) {
@@ -215,10 +215,10 @@ export const FiltersBadge = ({ chartId }:
FiltersBadgeProps) => {
setNativeIndicators(indicatorsInitialState);
} else if (prevChartStatus !== 'success') {
if (
- chart?.queriesResponse?.rejected_filters !==
- prevChart?.queriesResponse?.rejected_filters ||
- chart?.queriesResponse?.applied_filters !==
- prevChart?.queriesResponse?.applied_filters ||
+ chart?.queriesResponse?.[0]?.rejected_filters !==
+ prevChart?.queriesResponse?.[0]?.rejected_filters ||
+ chart?.queriesResponse?.[0]?.applied_filters !==
+ prevChart?.queriesResponse?.[0]?.applied_filters ||
nativeFilters !== prevNativeFilters ||
chartLayoutItems !== prevChartLayoutItems ||
dataMask !== prevDataMask ||
diff --git a/superset-frontend/src/explore/types.ts
b/superset-frontend/src/explore/types.ts
index 301c9a6862..708ffa9dfa 100644
--- a/superset-frontend/src/explore/types.ts
+++ b/superset-frontend/src/explore/types.ts
@@ -55,7 +55,7 @@ export interface ChartState {
latestQueryFormData: Partial<QueryFormData>;
sliceFormData: QueryFormData | null;
queryController: AbortController | null;
- queriesResponse: QueryData | null;
+ queriesResponse: QueryData[] | null;
triggerQuery: boolean;
}