This is an automated email from the ASF dual-hosted git repository. hugh pushed a commit to branch hm/ar-filters in repository https://gitbox.apache.org/repos/asf/superset.git
commit 38bb661de45e88f572f4d063a2573f36239e1a19 Author: Hugh A. Miles II <[email protected]> AuthorDate: Wed Jan 15 20:42:40 2025 +0000 placeholder dropdowns --- superset-frontend/src/features/alerts/AlertReportModal.tsx | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/superset-frontend/src/features/alerts/AlertReportModal.tsx b/superset-frontend/src/features/alerts/AlertReportModal.tsx index fb911eaadc..7e5592bdd1 100644 --- a/superset-frontend/src/features/alerts/AlertReportModal.tsx +++ b/superset-frontend/src/features/alerts/AlertReportModal.tsx @@ -1662,7 +1662,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({ > <StyledInputContainer> <div className="control-label"> - {t('Content type')} + {t('Content type')} hello filters... <span className="required">*</span> </div> <Select @@ -1750,6 +1750,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({ </> )} </StyledInputContainer> + {tabsEnabled && contentType === ContentType.Dashboard && ( <StyledInputContainer> <> @@ -1762,6 +1763,16 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({ placeholder={t('Select a tab')} /> </> + <> + <Select + ariaLabel={t('Select Filter')} + value={"name"} + /> + <Select + ariaLabel={t('Select Value')} + value={"value"} + /> + </> </StyledInputContainer> )} {isScreenshot && ( @@ -1784,6 +1795,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({ </div> </StyledInputContainer> )} + {(isReport || contentType === ContentType.Dashboard) && ( <div className="inline-container"> <StyledCheckbox
