This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new b12f515185 fix: re-enable cypress checks (#32008)
b12f515185 is described below
commit b12f515185c3555b7576a944eb250859e9fbc23a
Author: Maxime Beauchemin <[email protected]>
AuthorDate: Wed Jan 29 23:29:30 2025 -0800
fix: re-enable cypress checks (#32008)
---
.gitignore | 1 +
scripts/cypress_run.py | 1 +
.../cypress-base/cypress/e2e/dashboard/drillby.test.ts | 2 +-
.../cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts | 8 ++++----
.../cypress/e2e/dashboard/horizontalFilterBar.test.ts | 6 +++---
5 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/.gitignore b/.gitignore
index 67bc771f84..e8714d70ab 100644
--- a/.gitignore
+++ b/.gitignore
@@ -21,6 +21,7 @@
*.swp
__pycache__
+.aider.*
.local
.cache
.bento*
diff --git a/scripts/cypress_run.py b/scripts/cypress_run.py
index 7531aad8da..33984995ce 100644
--- a/scripts/cypress_run.py
+++ b/scripts/cypress_run.py
@@ -60,6 +60,7 @@ def run_cypress_for_test_file(
f"--browser {browser} "
f"--record --group {group_id} --tag {REPO},{GITHUB_EVENT_NAME}
"
f"--ci-build-id {build_id} "
+ f"--wait-for-missing-groups "
f"-- {chrome_flags}"
)
else:
diff --git
a/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts
b/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts
index e471d1da8c..c4c5ed4766 100644
--- a/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts
+++ b/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts
@@ -599,7 +599,7 @@ describe('Drill by modal', () => {
]);
});
- it.skip('Radar Chart', () => {
+ it('Radar Chart', () => {
testEchart('radar', 'Radar Chart', [
[182, 49],
[423, 91],
diff --git
a/superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts
b/superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts
index 4ebd64dd6e..f11aac4454 100644
--- a/superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts
+++ b/superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts
@@ -335,7 +335,7 @@ describe('Drill to detail modal', () => {
});
});
- describe.skip('Bar Chart', () => {
+ describe('Bar Chart', () => {
it('opens the modal with the correct filters', () => {
interceptSamples();
@@ -373,7 +373,7 @@ describe('Drill to detail modal', () => {
});
});
- describe.skip('Area Chart', () => {
+ describe('Area Chart', () => {
it('opens the modal with the correct filters', () => {
testTimeChart('echarts_area');
});
@@ -407,7 +407,7 @@ describe('Drill to detail modal', () => {
});
});
- describe.skip('World Map', () => {
+ describe('World Map', () => {
it('opens the modal with the correct filters', () => {
interceptSamples();
@@ -567,7 +567,7 @@ describe('Drill to detail modal', () => {
});
});
- describe.skip('Radar Chart', () => {
+ describe('Radar Chart', () => {
it('opens the modal with the correct filters', () => {
interceptSamples();
diff --git
a/superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts
b/superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts
index bcacae8a36..f1bfa9617e 100644
---
a/superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts
+++
b/superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts
@@ -176,7 +176,7 @@ describe('Horizontal FilterBar', () => {
validateFilterNameOnDashboard(testItems.topTenChart.filterColumn);
});
- it.skip('should spot changes in "more filters" and apply their values', ()
=> {
+ it('should spot changes in "more filters" and apply their values', () => {
cy.intercept(`/api/v1/chart/data?form_data=**`).as('chart');
prepareDashboardFilters([
{ name: 'test_1', column: 'country_name', datasetId: 2 },
@@ -204,7 +204,7 @@ describe('Horizontal FilterBar', () => {
);
});
- it.skip('should focus filter and open "more filters" programmatically', ()
=> {
+ it('should focus filter and open "more filters" programmatically', () => {
prepareDashboardFilters([
{ name: 'test_1', column: 'country_name', datasetId: 2 },
{ name: 'test_2', column: 'country_code', datasetId: 2 },
@@ -231,7 +231,7 @@ describe('Horizontal FilterBar', () => {
cy.get('.ant-select-focused').should('be.visible');
});
- it.skip('should show tag count and one plain tag on focus and only count on
blur in select ', () => {
+ it('should show tag count and one plain tag on focus and only count on blur
in select ', () => {
prepareDashboardFilters([
{ name: 'test_1', column: 'country_name', datasetId: 2 },
]);
