This is an automated email from the ASF dual-hosted git repository. dpgaspar pushed a commit to branch fix/ephemeral-envs-v2 in repository https://gitbox.apache.org/repos/asf/superset.git
commit 7688817c013eb292efe25d28668509e3b5c709a6 Author: Daniel Gaspar <[email protected]> AuthorDate: Thu Jan 30 13:14:27 2025 +0000 fix(ci): ephemeral env, handle different label, create comment --- .github/workflows/ephemeral-env.yml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ephemeral-env.yml b/.github/workflows/ephemeral-env.yml index 4c4747f5e2..0529fbe681 100644 --- a/.github/workflows/ephemeral-env.yml +++ b/.github/workflows/ephemeral-env.yml @@ -50,7 +50,7 @@ jobs: echo "result=up" >> $GITHUB_OUTPUT else echo "result=noop" >> $GITHUB_OUTPUT - exit 1 + exit 0 fi - name: Get event SHA @@ -274,20 +274,22 @@ jobs: with: github-token: ${{github.token}} script: | + const issue_number = context.payload.inputs?.issue_number || context.issue.number; github.rest.issues.createComment({ - issue_number: ${{ github.event.inputs.issue_number || github.event.issue.number }}, + issue_number: issue_number, owner: context.repo.owner, repo: context.repo.repo, - body: '@${{ github.actor }} Ephemeral environment spinning up at http://${{ steps.get-ip.outputs.ip }}:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.' - }) + body: `@${{ github.actor }} Ephemeral environment spinning up at http://${{ steps.get-ip.outputs.ip }}:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.` + }); - name: Comment (failure) if: ${{ failure() }} uses: actions/github-script@v7 with: github-token: ${{github.token}} script: | + const issue_number = context.payload.inputs?.issue_number || context.issue.number; github.rest.issues.createComment({ - issue_number: ${{ github.event.inputs.issue_number || github.event.issue.number }}, + issue_number: issue_number, owner: context.repo.owner, repo: context.repo.repo, body: '@${{ github.event.inputs.user_login || github.event.comment.user.login }} Ephemeral environment creation failed. Please check the Actions logs for details.'
