This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch show_percentage_false
in repository https://gitbox.apache.org/repos/asf/superset.git

commit ea8faaefc5662fb2a70e2c00ea14337f1072d7ae
Author: Maxime Beauchemin <[email protected]>
AuthorDate: Mon Feb 10 13:38:44 2025 -0800

    fix: set `Rich tooltip` -> 'Show percentage' to false by default
    
    Many users have reported that they prefer having the show percentage option 
in timeseries as false by default. While it's generally a good feature and many 
might want it, default should be lightweight and optimize for less clutter.
    
    From my local tests, the false default should affect charts that haven't 
been saved since the feature was turned on.
    
    Open to input or debatting which default option is best, but given that 
many users reported it, and that it's a bit of a visual regression / change in 
some dashboard, I thought we'd switch it off.
---
 superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx 
b/superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx
index db7daa02b6..5c52bb1762 100644
--- a/superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx
+++ b/superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx
@@ -230,7 +230,7 @@ const tooltipPercentageControl: ControlSetItem = {
     type: 'CheckboxControl',
     label: t('Show percentage'),
     renderTrigger: true,
-    default: true,
+    default: false,
     description: t('Whether to display the percentage value in the tooltip'),
     visibility: ({ controls, form_data }: ControlPanelsContainerProps) =>
       Boolean(controls?.rich_tooltip?.value) &&

Reply via email to