This is an automated email from the ASF dual-hosted git repository.
villebro pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new c1abe1ec44 chore(ci): show more failed pre-commit context (#32517)
c1abe1ec44 is described below
commit c1abe1ec4443a71cd5b85a6553d6985017cf2f5f
Author: Ville Brofeldt <[email protected]>
AuthorDate: Wed Mar 5 11:39:07 2025 -0800
chore(ci): show more failed pre-commit context (#32517)
---
.github/workflows/pre-commit.yml | 15 +++++++++++++--
superset-frontend/package-lock.json | 14 --------------
2 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml
index d2b89ac2e4..8bebb63a1e 100644
--- a/.github/workflows/pre-commit.yml
+++ b/.github/workflows/pre-commit.yml
@@ -59,8 +59,19 @@ jobs:
# Skip auto-fixing in CI to ensure changes are committed locally
export SKIP_FIX=1
pre-commit run --all-files
- if [ $? -ne 0 ] || ! git diff --quiet --exit-code; then
- echo "❌ Pre-commit check failed."
+ PRE_COMMIT_EXIT_CODE=$?
+ git diff --quiet --exit-code
+ GIT_DIFF_EXIT_CODE=$?
+ if [ "${PRE_COMMIT_EXIT_CODE}" -ne 0 ] || [ "${GIT_DIFF_EXIT_CODE}"
-ne 0 ]; then
+ if [ "${PRE_COMMIT_EXIT_CODE}" -ne 0 ]; then
+ echo "❌ Pre-commit check failed (exit code: ${EXIT_CODE})."
+ else
+ echo "❌ Git working directory is dirty after running pre-commit."
+ echo "📌 This likely means that pre-commit made changes that were
not committed."
+ echo "🔍 Modified files:"
+ git diff --name-only
+ fi
+
echo "🚒 To prevent/address this CI issue, please install/use
pre-commit locally."
echo "📖 More details here:
https://superset.apache.org/docs/contributing/development#git-hooks";
exit 1
diff --git a/superset-frontend/package-lock.json
b/superset-frontend/package-lock.json
index dcc9c058ad..22bb8e4162 100644
--- a/superset-frontend/package-lock.json
+++ b/superset-frontend/package-lock.json
@@ -50792,20 +50792,6 @@
"react-dom": "^17.0.2"
}
},
- "plugins/plugin-chart-pivot-table/node_modules/@babel/types": {
- "version": "7.26.9",
- "resolved": "https://registry.npmjs.org/@babel/types/-/types-7.26.9.tgz";,
- "integrity":
"sha512-Y3IR1cRnOxOCDvMmNiym7XpXQ93iGDDPHx+Zj+NM+rg0fBaShfQLkg+hKPaZCEvg5N/LeCo4+Rj/i3FuJsIQaw==",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "@babel/helper-string-parser": "^7.25.9",
- "@babel/helper-validator-identifier": "^7.25.9"
- },
- "engines": {
- "node": ">=6.9.0"
- }
- },
"plugins/plugin-chart-table": {
"name": "@superset-ui/plugin-chart-table",
"version": "0.20.3",
