(superset) branch master updated: fix(spreadsheet uploads): make file extension comparisons case-insensitive (#32696)

[rusackas]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 6a13ab8920 fix(spreadsheet uploads): make file extension comparisons 
case-insensitive (#32696)
6a13ab8920 is described below

commit 6a13ab8920dc95ad64036151f83d89c195ca441c
Author: Sam Firke <sfi...@users.noreply.github.com>
AuthorDate: Mon Mar 17 13:31:11 2025 -0400

    fix(spreadsheet uploads): make file extension comparisons case-insensitive 
(#32696)
---
 superset-frontend/src/features/databases/UploadDataModel/index.tsx | 7 +++++--
 superset/databases/schemas.py                                      | 5 ++++-
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/superset-frontend/src/features/databases/UploadDataModel/index.tsx 
b/superset-frontend/src/features/databases/UploadDataModel/index.tsx
index f07debf914..7b51b7a0b4 100644
--- a/superset-frontend/src/features/databases/UploadDataModel/index.tsx
+++ b/superset-frontend/src/features/databases/UploadDataModel/index.tsx
@@ -185,8 +185,11 @@ export const validateUploadFileExtension = (
     return false;
   }
 
-  const fileType = extensionMatch[1];
-  return allowedExtensions.includes(fileType);
+  const fileType = extensionMatch[1].toLowerCase();
+  const lowerCaseAllowedExtensions = allowedExtensions.map(ext =>
+    ext.toLowerCase(),
+  );
+  return lowerCaseAllowedExtensions.includes(fileType);
 };
 
 interface StyledSwitchContainerProps extends SwitchProps {
diff --git a/superset/databases/schemas.py b/superset/databases/schemas.py
index bd330b0951..f225a1458d 100644
--- a/superset/databases/schemas.py
+++ b/superset/databases/schemas.py
@@ -1086,7 +1086,10 @@ class BaseUploadFilePostSchemaMixin(Schema):
     def validate_file_extension(self, file: FileStorage) -> None:
         allowed_extensions = current_app.config["ALLOWED_EXTENSIONS"]
         file_suffix = Path(file.filename).suffix
-        if not file_suffix or file_suffix[1:] not in allowed_extensions:
+        if not file_suffix:
+            raise ValidationError([_("File extension is not allowed.")])
+        # Make case-insensitive comparison
+        if file_suffix[1:].lower() not in [ext.lower() for ext in 
allowed_extensions]:
             raise ValidationError([_("File extension is not allowed.")])