This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hm/ar-filters
in repository https://gitbox.apache.org/repos/asf/superset.git
commit ae038216bbf9e04f0b3885e77d025b534d926e6f
Author: Hugh Miles <hughmi...@gmail.com>
AuthorDate: Tue Mar 25 13:59:33 2025 -0400
fix Icons update
---
.../src/features/alerts/AlertReportModal.tsx | 30 ++++++++++++----------
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/superset-frontend/src/features/alerts/AlertReportModal.tsx
b/superset-frontend/src/features/alerts/AlertReportModal.tsx
index 2a9604f4ca..5b7eb41570 100644
--- a/superset-frontend/src/features/alerts/AlertReportModal.tsx
+++ b/superset-frontend/src/features/alerts/AlertReportModal.tsx
@@ -523,7 +523,14 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
const [nativeFilterOptions, setNativeFilterOptions] = useState<object[]>([]);
const [tabNativeFilters, setTabNativeFilters] = useState<object>({});
const [nativeFilterData, setNativeFilterData] =
useState<ExtraNativeFilter[]>(
- [{}],
+ [
+ {
+ nativeFilterId: null,
+ columnLabel: '',
+ columnName: '',
+ filterValues: [],
+ },
+ ],
);
console.log(nativeFilterData);
@@ -1980,7 +1987,6 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
<div>
{fields.map(({ key, name }) => (
<div className="filters-container" key={key}>
- {console.log(name)}
<div className="filters-dash-container">
<div className="control-label">
<span>{t('Select Dashboard Filter')}</span>
@@ -2023,17 +2029,15 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
mode="multiple"
/>
</div>
- {name !== 0 && (
- <div className="filters-delete">
- <Icons.Trash
- className="filters-trashcan"
- onClick={() => {
- handleRemoveFilterField(name);
- remove(name);
- }}
- />
- </div>
- )}
+ <div className="filters-delete">
+ <Icons.DeleteOutlined
+ className="filters-trashcan"
+ onClick={() => {
+ handleRemoveFilterField(name);
+ remove(name);
+ }}
+ />
+ </div>
</div>
))}
<div className="filters-add-container">
