This is an automated email from the ASF dual-hosted git repository. vavila pushed a commit to branch fix/time-grain-macro-on-table-chart in repository https://gitbox.apache.org/repos/asf/superset.git
commit 84c9297397795368e959f87b6cf95d842dd4714a Author: Vitor Avila <[email protected]> AuthorDate: Wed Mar 26 08:35:05 2025 -0300 fix(Jinja): Emit time grain to table charts even if they don't have a temporal column --- superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts | 5 ----- superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx | 1 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts b/superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts index 7068ab1193..5b9cb684ed 100644 --- a/superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts +++ b/superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts @@ -198,11 +198,6 @@ const buildQuery: BuildQuery<TableChartFormData> = ( (ownState.currentPage ?? 0) * (ownState.pageSize ?? 0); } - if (!temporalColumn) { - // This query is not using temporal column, so it doesn't need time grain - extras.time_grain_sqla = undefined; - } - let queryObject = { ...baseQueryObject, columns, diff --git a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx index 933ee6a0c1..e6f9bf9bff 100644 --- a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx +++ b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx @@ -233,6 +233,7 @@ const config: ControlPanelConfig = { name: 'time_grain_sqla', config: { ...sharedControls.time_grain_sqla, + default: null, visibility: ({ controls }) => { const dttmLookup = Object.fromEntries( ensureIsArray(controls?.groupby?.options).map(option => [
