This is an automated email from the ASF dual-hosted git repository.
jli pushed a commit to branch 4.1
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/4.1 by this push:
new ccfc07de83 fix(fe/dashboard-list): display modifier info for `Last
modified` data (#32035)
ccfc07de83 is described below
commit ccfc07de83d26b0c3e66766c7bdbd74dcfc9951c
Author: Đỗ Trọng Hải <[email protected]>
AuthorDate: Sat Feb 22 02:14:08 2025 +0700
fix(fe/dashboard-list): display modifier info for `Last modified` data
(#32035)
Signed-off-by: hainenber <[email protected]>
(cherry picked from commit 88cf2d5c39d7d44757e990aed046dd62447256b3)
---
superset-frontend/src/pages/DashboardList/DashboardList.test.jsx | 2 +-
superset-frontend/src/pages/DashboardList/index.tsx | 5 ++++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/superset-frontend/src/pages/DashboardList/DashboardList.test.jsx
b/superset-frontend/src/pages/DashboardList/DashboardList.test.jsx
index 90a397666e..6761e1e040 100644
--- a/superset-frontend/src/pages/DashboardList/DashboardList.test.jsx
+++ b/superset-frontend/src/pages/DashboardList/DashboardList.test.jsx
@@ -161,7 +161,7 @@ describe('DashboardList', () => {
const callsD = fetchMock.calls(/dashboard\/\?q/);
expect(callsD).toHaveLength(1);
expect(callsD[0][0]).toMatchInlineSnapshot(
-
`"http://localhost/api/v1/dashboard/?q=(order_column:changed_on_delta_humanized,order_direction:desc,page:0,page_size:25,select_columns:!(id,dashboard_title,published,url,slug,changed_by,changed_on_delta_humanized,owners.id,owners.first_name,owners.last_name,owners,tags.id,tags.name,tags.type,status,certified_by,certification_details,changed_on))"`,
+
`"http://localhost/api/v1/dashboard/?q=(order_column:changed_on_delta_humanized,order_direction:desc,page:0,page_size:25,select_columns:!(id,dashboard_title,published,url,slug,changed_by,changed_by.id,changed_by.first_name,changed_by.last_name,changed_on_delta_humanized,owners,owners.id,owners.first_name,owners.last_name,tags.id,tags.name,tags.type,status,certified_by,certification_details,changed_on))"`,
);
});
diff --git a/superset-frontend/src/pages/DashboardList/index.tsx
b/superset-frontend/src/pages/DashboardList/index.tsx
index 361168f418..edc4e5b5ee 100644
--- a/superset-frontend/src/pages/DashboardList/index.tsx
+++ b/superset-frontend/src/pages/DashboardList/index.tsx
@@ -118,11 +118,14 @@ const DASHBOARD_COLUMNS_TO_FETCH = [
'url',
'slug',
'changed_by',
+ 'changed_by.id',
+ 'changed_by.first_name',
+ 'changed_by.last_name',
'changed_on_delta_humanized',
+ 'owners',
'owners.id',
'owners.first_name',
'owners.last_name',
- 'owners',
'tags.id',
'tags.name',
'tags.type',
