This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch template_less_preset_theme_editor in repository https://gitbox.apache.org/repos/asf/superset.git
commit 13eb4b913852cb164f11b15a40dfa9e286f117a7 Author: Maxime Beauchemin <[email protected]> AuthorDate: Tue Apr 1 16:23:06 2025 -0700 Fix storybook + raw button for ThemeEditor --- superset-frontend/.storybook/preview.jsx | 1 - superset-frontend/src/components/ThemeEditor/index.tsx | 8 +++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/superset-frontend/.storybook/preview.jsx b/superset-frontend/.storybook/preview.jsx index 6f56faec57..8592617c7e 100644 --- a/superset-frontend/.storybook/preview.jsx +++ b/superset-frontend/.storybook/preview.jsx @@ -71,7 +71,6 @@ const themeDecorator = (Story, context) => { return ( <themeObject.SupersetThemeProvider> <App> - <GlobalStyles /> <GlobalStylesOverrides /> <Layout style={{ diff --git a/superset-frontend/src/components/ThemeEditor/index.tsx b/superset-frontend/src/components/ThemeEditor/index.tsx index c7b881066b..641d59be69 100644 --- a/superset-frontend/src/components/ThemeEditor/index.tsx +++ b/superset-frontend/src/components/ThemeEditor/index.tsx @@ -239,12 +239,10 @@ export default function ThemeEditor() { return ( <> <Tooltip title={t('Edit Theme')} placement="bottom"> - <Button - buttonStyle="link" - icon={<Icons.BgColorsOutlined iconSize="l" />} + <Icons.BgColorsOutlined + iconSize="l" onClick={() => setIsModalOpen(true)} - aria-label={t('Edit theme')} - size="large" + className="action-button" /> </Tooltip> <Modal
