This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch template_less
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 1dd8a761136cb811ecd486e4ae9684adc7995707
Author: Maxime Beauchemin <[email protected]>
AuthorDate: Fri Mar 28 17:40:30 2025 -0700

    set Global body bg color to colorBgBase
---
 superset-frontend/src/GlobalStyles.tsx                           | 4 ++++
 superset-frontend/src/components/CachedLabel/index.tsx           | 2 +-
 superset-frontend/src/components/PageHeaderWithActions/index.tsx | 3 +--
 superset-frontend/src/components/ThemeEditor/index.tsx           | 2 +-
 4 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/superset-frontend/src/GlobalStyles.tsx 
b/superset-frontend/src/GlobalStyles.tsx
index 0780bbc8c4..7ff54e3c37 100644
--- a/superset-frontend/src/GlobalStyles.tsx
+++ b/superset-frontend/src/GlobalStyles.tsx
@@ -23,6 +23,10 @@ import 'react-js-cron/dist/styles.css';
 export const GlobalStyles = () => (
   <Global
     styles={theme => css`
+      body {
+        background-color: ${theme.colorBgBase};
+      }
+
       h1,
       h2,
       h3,
diff --git a/superset-frontend/src/components/CachedLabel/index.tsx 
b/superset-frontend/src/components/CachedLabel/index.tsx
index 3c01ab6052..8cd5b51f47 100644
--- a/superset-frontend/src/components/CachedLabel/index.tsx
+++ b/superset-frontend/src/components/CachedLabel/index.tsx
@@ -21,7 +21,7 @@ import { useState, MouseEventHandler, FC } from 'react';
 import { t } from '@superset-ui/core';
 import Label from 'src/components/Label';
 import { Tooltip } from 'src/components/Tooltip';
-import Icons from 'src/components/Icons';
+import { Icons } from 'src/components/Icons';
 import { TooltipContent } from './TooltipContent';
 
 export interface CacheLabelProps {
diff --git a/superset-frontend/src/components/PageHeaderWithActions/index.tsx 
b/superset-frontend/src/components/PageHeaderWithActions/index.tsx
index 656eaa7d4c..553d4d0f20 100644
--- a/superset-frontend/src/components/PageHeaderWithActions/index.tsx
+++ b/superset-frontend/src/components/PageHeaderWithActions/index.tsx
@@ -21,8 +21,7 @@ import { css, SupersetTheme, t, useTheme } from 
'@superset-ui/core';
 import { Dropdown, DropdownProps } from 'src/components/Dropdown';
 import { TooltipPlacement } from 'src/components/Tooltip';
 import { Icons } from 'src/components/Icons';
-import {
-  DynamicEditableTitle,
+import DynamicEditableTitle, {
   DynamicEditableTitleProps,
 } from '../DynamicEditableTitle';
 import CertifiedBadge, { CertifiedBadgeProps } from '../CertifiedBadge';
diff --git a/superset-frontend/src/components/ThemeEditor/index.tsx 
b/superset-frontend/src/components/ThemeEditor/index.tsx
index aa8978e008..2c819393d1 100644
--- a/superset-frontend/src/components/ThemeEditor/index.tsx
+++ b/superset-frontend/src/components/ThemeEditor/index.tsx
@@ -25,7 +25,7 @@ import {
   SupersetTheme,
 } from '@superset-ui/core';
 import { useState } from 'react';
-import Icons from 'src/components/Icons';
+import { Icons } from 'src/components/Icons';
 import { JsonEditor } from 'src/components/AsyncAceEditor';
 
 interface ThemeEditorProps {

Reply via email to