(superset) branch eslint-cleanup updated: more fixes

[rusackas]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch eslint-cleanup
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/eslint-cleanup by this push:
     new e3afbb3c05 more fixes
e3afbb3c05 is described below

commit e3afbb3c056b45133c5bdc18abe149b56ad72373
Author: Evan Rusackas <e...@rusackas.com>
AuthorDate: Fri Mar 21 11:45:16 2025 -0600

    more fixes
---
 .../plugins/plugin-chart-echarts/src/components/Echart.tsx          | 5 ++++-
 superset-frontend/src/features/tags/BulkTagModal.tsx                | 2 +-
 superset-frontend/src/features/tags/TagCard.tsx                     | 3 ---
 superset-frontend/src/features/tags/TagModal.tsx                    | 6 +++---
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git 
a/superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx 
b/superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx
index 5b4f396640..e3906a2681 100644
--- a/superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx
+++ b/superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx
@@ -30,7 +30,9 @@ import {
 import { useSelector } from 'react-redux';
 
 import { styled } from '@superset-ui/core';
-import { use, init, EChartsType, registerLocale } from 'echarts/core';
+import { use, init, EChartsType } from 'echarts/core';
+// @ts-ignore
+import { registerLocale } from 'echarts/lib/core/locale';
 import {
   SankeyChart,
   PieChart,
@@ -174,6 +176,7 @@ function Echart(
       }
 
       if (!chartRef.current) {
+        // @ts-ignore
         chartRef.current = init(divRef.current, null, { locale });
       }
 
diff --git a/superset-frontend/src/features/tags/BulkTagModal.tsx 
b/superset-frontend/src/features/tags/BulkTagModal.tsx
index 3195461285..511162c213 100644
--- a/superset-frontend/src/features/tags/BulkTagModal.tsx
+++ b/superset-frontend/src/features/tags/BulkTagModal.tsx
@@ -81,7 +81,7 @@ const BulkTagModal: FC<BulkTagModalProps> = ({
         }
         addSuccessToast(t('Tagged %s %ss', tagged.length, resourceName));
       })
-      .catch(err => {
+      .catch(() => {
         addDangerToast(t('Failed to tag items'));
       });
 
diff --git a/superset-frontend/src/features/tags/TagCard.tsx 
b/superset-frontend/src/features/tags/TagCard.tsx
index 34f26a3f50..30c2453a9b 100644
--- a/superset-frontend/src/features/tags/TagCard.tsx
+++ b/superset-frontend/src/features/tags/TagCard.tsx
@@ -44,10 +44,7 @@ interface TagCardProps {
 function TagCard({
   tag,
   hasPerm,
-  _bulkSelectEnabled, // Prefix with underscore to indicate intentionally 
unused
-  _tagFilter, // Prefix with underscore to indicate intentionally unused
   refreshData,
-  _userId, // Prefix with underscore to indicate intentionally unused
   addDangerToast,
   addSuccessToast,
   showThumbnails,
diff --git a/superset-frontend/src/features/tags/TagModal.tsx 
b/superset-frontend/src/features/tags/TagModal.tsx
index b7b7138627..0f97d68f7a 100644
--- a/superset-frontend/src/features/tags/TagModal.tsx
+++ b/superset-frontend/src/features/tags/TagModal.tsx
@@ -125,7 +125,7 @@ const TagModal: FC<TagModalProps> = ({
           setChartsToTag(resourceMap[TaggableResources.Chart]);
           setSavedQueriesToTag(resourceMap[TaggableResources.SavedQuery]);
         },
-        (error: Response) => {
+        () => {
           addDangerToast('Error Fetching Tagged Objects');
         },
       );
@@ -233,7 +233,7 @@ const TagModal: FC<TagModalProps> = ({
           objects_to_tag: [...dashboards, ...charts, ...savedQueries],
         },
       })
-        .then(({ json = {} }) => {
+        .then(() => {
           refreshData();
           clearTagForm();
           addSuccessToast(t('Tag updated'));
@@ -251,7 +251,7 @@ const TagModal: FC<TagModalProps> = ({
           objects_to_tag: [...dashboards, ...charts, ...savedQueries],
         },
       })
-        .then(({ json = {} }) => {
+        .then(() => {
           refreshData();
           clearTagForm();
           addSuccessToast(t('Tag created'));