This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hm/ar-filters
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/hm/ar-filters by this push:
new 424d59fb56 add feature flag
424d59fb56 is described below
commit 424d59fb5639d672687c31904957437b79de0f76
Author: Hugh Miles <[email protected]>
AuthorDate: Tue Apr 8 11:44:58 2025 -0400
add feature flag
---
.../packages/superset-ui-core/src/utils/featureFlags.ts | 1 +
superset-frontend/src/features/alerts/AlertReportModal.tsx | 5 ++++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git
a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
index 7890fd7c57..5024e83eab 100644
--- a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
+++ b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
@@ -26,6 +26,7 @@ export enum FeatureFlag {
AlertReports = 'ALERT_REPORTS',
AlertReportTabs = 'ALERT_REPORT_TABS',
AlertReportSlackV2 = 'ALERT_REPORT_SLACK_V2',
+ AlertReportsFilter = 'ALERT_REPORTS_FILTER',
AllowFullCsvExport = 'ALLOW_FULL_CSV_EXPORT',
AvoidColorsCollision = 'AVOID_COLORS_COLLISION',
ChartPluginsExperimental = 'CHART_PLUGINS_EXPERIMENTAL',
diff --git a/superset-frontend/src/features/alerts/AlertReportModal.tsx
b/superset-frontend/src/features/alerts/AlertReportModal.tsx
index b124316c4b..12abf05de6 100644
--- a/superset-frontend/src/features/alerts/AlertReportModal.tsx
+++ b/superset-frontend/src/features/alerts/AlertReportModal.tsx
@@ -587,6 +587,7 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
const formatOptionEnabled =
isFeatureEnabled(FeatureFlag.AlertsAttachReports) || isReport;
const tabsEnabled = isFeatureEnabled(FeatureFlag.AlertReportTabs);
+ const filtersEnabled = isFeatureEnabled(FeatureFlag.AlertReportsFilter);
const [notificationAddState, setNotificationAddState] =
useState<NotificationAddStatus>('active');
@@ -597,6 +598,8 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
const [emailSubject, setEmailSubject] = useState<string>('');
const [emailError, setEmailError] = useState(false);
+ console.log('filtersEnabled', filtersEnabled);
+
const onNotificationAdd = () => {
setNotificationSettings([
...notificationSettings,
@@ -2066,7 +2069,7 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
</>
)}
</StyledInputContainer>
- {tabsEnabled && contentType === ContentType.Dashboard && (
+ {filtersEnabled && contentType === ContentType.Dashboard && (
<StyledInputContainer>
<div>
<div className="control-label">{t('Select tab')}</div>