This is an automated email from the ASF dual-hosted git repository. enzomartellucci pushed a commit to branch enxdev/refactor/replace-native-html-elements-with-antd5-components in repository https://gitbox.apache.org/repos/asf/superset.git
commit 7c0721e95a940acf07de2ee6ba47d075e5e5835a Author: Enzo Martellucci <[email protected]> AuthorDate: Thu Apr 17 17:12:49 2025 +0200 refactor(buildErrorTooltipMessage): replace <ul> element with antd5 List component --- .../features/alerts/buildErrorTooltipMessage.tsx | 23 +++++++++++----------- .../alerts/components/ValidatedPanelHeader.tsx | 2 +- .../databases/DatabaseModal/ExtraOptions.tsx | 2 +- 3 files changed, 14 insertions(+), 13 deletions(-) diff --git a/superset-frontend/src/features/alerts/buildErrorTooltipMessage.tsx b/superset-frontend/src/features/alerts/buildErrorTooltipMessage.tsx index eece9fb603..7d2bf3729a 100644 --- a/superset-frontend/src/features/alerts/buildErrorTooltipMessage.tsx +++ b/superset-frontend/src/features/alerts/buildErrorTooltipMessage.tsx @@ -16,15 +16,11 @@ * specific language governing permissions and limitations * under the License. */ -import { styled } from '@superset-ui/core'; +import { List } from 'src/components'; +import { Typography } from 'src/components/Typography'; import { ValidationObject } from './types'; import { TRANSLATIONS } from './AlertReportModal'; -const StyledList = styled.ul` - margin-left: ${({ theme }) => theme.sizeUnit * 2}px; - padding-inline-start: ${({ theme }) => theme.sizeUnit * 3}px; -`; - export const buildErrorTooltipMessage = ( validationStatus: ValidationObject, ) => { @@ -38,11 +34,16 @@ export const buildErrorTooltipMessage = ( return ( <div> {TRANSLATIONS.ERROR_TOOLTIP_MESSAGE} - <StyledList> - {sectionErrors.map(err => ( - <li key={err}>{err}</li> - ))} - </StyledList> + <List + dataSource={sectionErrors} + renderItem={err => ( + <List.Item> + <Typography.Text>• {err}</Typography.Text> + </List.Item> + )} + size="small" + split={false} + /> </div> ); }; diff --git a/superset-frontend/src/features/alerts/components/ValidatedPanelHeader.tsx b/superset-frontend/src/features/alerts/components/ValidatedPanelHeader.tsx index e585861201..a19f82597e 100644 --- a/superset-frontend/src/features/alerts/components/ValidatedPanelHeader.tsx +++ b/superset-frontend/src/features/alerts/components/ValidatedPanelHeader.tsx @@ -19,7 +19,7 @@ import { t, useTheme } from '@superset-ui/core'; import { Icons } from 'src/components/Icons'; import { Space } from 'src/components/Space'; -import Typography from 'src/components/Typography'; +import { Typography } from 'src/components/Typography'; const ValidatedPanelHeader = ({ title, diff --git a/superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx b/superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx index bb723e8beb..ce30a04205 100644 --- a/superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx +++ b/superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx @@ -33,7 +33,7 @@ import { InfoTooltip, type CheckboxChangeEvent, } from 'src/components'; -import Typography from 'src/components/Typography'; +import { Typography } from 'src/components/Typography'; import { StyledInputContainer, StyledJsonEditor,
