This is an automated email from the ASF dual-hosted git repository. beto pushed a commit to branch bignumber-d3format in repository https://gitbox.apache.org/repos/asf/superset.git
commit 77588ef6e305ecac44b40b1606a1f819c7be56bc Author: Beto Dealmeida <[email protected]> AuthorDate: Fri May 2 08:52:19 2025 -0400 fix: apply d3 format to BigNumber(s) --- .../src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts | 10 +++++++++- .../src/BigNumber/BigNumberTotal/transformProps.ts | 2 +- .../src/BigNumber/BigNumberWithTrendline/transformProps.ts | 2 +- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts b/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts index a40f18b24c..98193a39e6 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts @@ -18,6 +18,7 @@ */ import dayjs from 'dayjs'; import utc from 'dayjs/plugin/utc'; +import { Metric } from '@superset-ui/chart-controls'; import { ChartProps, getMetricLabel, @@ -103,6 +104,13 @@ export default function transformProps(chartProps: ChartProps) { adhoc_filter.operator === 'TEMPORAL_RANGE', )?.[0]; + let metricEntry: Metric | undefined; + if (chartProps.datasource?.metrics) { + metricEntry = chartProps.datasource.metrics.find( + metricItem => metricItem.metric_name === metric, + ); + } + const isCustomOrInherit = timeComparison === 'custom' || timeComparison === 'inherit'; let dataOffset: string[] = []; @@ -143,7 +151,7 @@ export default function transformProps(chartProps: ChartProps) { metric, currencyFormats, columnFormats, - yAxisFormat, + metricEntry?.d3format || yAxisFormat, currencyFormat, ); diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/transformProps.ts b/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/transformProps.ts index c0f9b2baeb..448250b3d0 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/transformProps.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/transformProps.ts @@ -85,7 +85,7 @@ export default function transformProps( metric, currencyFormats, columnFormats, - yAxisFormat, + metricEntry?.d3format || yAxisFormat, currencyFormat, ); diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts b/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts index 3d933208fd..0f9ec9688f 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts @@ -200,7 +200,7 @@ export default function transformProps( metric, currencyFormats, columnFormats, - yAxisFormat, + metricEntry?.d3format || yAxisFormat, currencyFormat, );
