This is an automated email from the ASF dual-hosted git repository.
jli pushed a commit to branch 6.0
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/6.0 by this push:
new acec8743c0 fix(theming): Icons in ExecutionLogList and Country map
chart tooltip theme consistency (#34828)
acec8743c0 is described below
commit acec8743c06150181c72e907eef9678df23c0a26
Author: Rafael Benitez <[email protected]>
AuthorDate: Fri Sep 5 18:02:53 2025 -0400
fix(theming): Icons in ExecutionLogList and Country map chart tooltip theme
consistency (#34828)
(cherry picked from commit bef1f4d045e7ada6902f00e1038ee9a5cbd0530c)
---
.../src/ReactCountryMap.jsx | 2 ++
.../features/alerts/components/AlertStatusIcon.tsx | 38 ++++++++++++++--------
2 files changed, 27 insertions(+), 13 deletions(-)
diff --git
a/superset-frontend/plugins/legacy-plugin-chart-country-map/src/ReactCountryMap.jsx
b/superset-frontend/plugins/legacy-plugin-chart-country-map/src/ReactCountryMap.jsx
index ba8f06eaeb..9d8413b427 100644
---
a/superset-frontend/plugins/legacy-plugin-chart-country-map/src/ReactCountryMap.jsx
+++
b/superset-frontend/plugins/legacy-plugin-chart-country-map/src/ReactCountryMap.jsx
@@ -58,11 +58,13 @@ export default styled(CountryMap)`
}
.superset-legacy-chart-country-map text.result-text {
+ fill: ${theme.colorText};
font-weight: ${theme.fontWeightLight};
font-size: ${theme.fontSizeXL}px;
}
.superset-legacy-chart-country-map text.big-text {
+ fill: ${theme.colorText};
font-weight: ${theme.fontWeightStrong};
font-size: ${theme.fontSizeLG}px;
}
diff --git
a/superset-frontend/src/features/alerts/components/AlertStatusIcon.tsx
b/superset-frontend/src/features/alerts/components/AlertStatusIcon.tsx
index 1258ea6aad..ccec4ddf5c 100644
--- a/superset-frontend/src/features/alerts/components/AlertStatusIcon.tsx
+++ b/superset-frontend/src/features/alerts/components/AlertStatusIcon.tsx
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { t, SupersetTheme, useTheme } from '@superset-ui/core';
+import { t, SupersetTheme, useTheme, css } from '@superset-ui/core';
import { Tooltip } from '@superset-ui/core/components';
import { Icons } from '@superset-ui/core/components/Icons';
import { AlertState } from '../types';
@@ -32,7 +32,7 @@ function getStatusColor(
case AlertState.Error:
return theme.colorErrorText;
case AlertState.Success:
- return isReportEnabled ? theme.colorSuccessText : theme.colorErrorText;
+ return theme.colorSuccessText;
case AlertState.Noop:
return theme.colorSuccessText;
case AlertState.Grace:
@@ -57,9 +57,7 @@ export default function AlertStatusIcon({
};
switch (state) {
case AlertState.Success:
- lastStateConfig.icon = isReportEnabled
- ? Icons.CheckOutlined
- : Icons.WarningOutlined;
+ lastStateConfig.icon = Icons.CheckOutlined;
lastStateConfig.label = isReportEnabled
? t('Report sent')
: t('Alert triggered, notification sent');
@@ -95,16 +93,30 @@ export default function AlertStatusIcon({
lastStateConfig.status = AlertState.Noop;
}
const Icon = lastStateConfig.icon;
+ const isRunningIcon = state === AlertState.Working;
return (
<Tooltip title={lastStateConfig.label} placement="bottomLeft">
- <Icon
- iconSize="m"
- iconColor={getStatusColor(
- lastStateConfig.status,
- isReportEnabled,
- theme,
- )}
- />
+ <span
+ css={
+ isRunningIcon
+ ? css`
+ display: inline-flex;
+ align-items: center;
+ justify-content: center;
+ transform: scale(1.8);
+ `
+ : undefined
+ }
+ >
+ <Icon
+ iconSize="m"
+ iconColor={getStatusColor(
+ lastStateConfig.status,
+ isReportEnabled,
+ theme,
+ )}
+ />
+ </span>
</Tooltip>
);
}
