This is an automated email from the ASF dual-hosted git repository.
elizabeth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new ccc0e3dbb2 fix: Log Celery task failures with a signal handler (#35595)
ccc0e3dbb2 is described below
commit ccc0e3dbb2bfbd974032a43bce61804245e5c325
Author: Elizabeth Thompson <[email protected]>
AuthorDate: Tue Oct 14 13:01:29 2025 -0700
fix: Log Celery task failures with a signal handler (#35595)
Co-authored-by: Claude <[email protected]>
---
superset/tasks/scheduler.py | 29 +++++++++++++++++++++++++++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/superset/tasks/scheduler.py b/superset/tasks/scheduler.py
index c59b4f4dd8..da9765a8d6 100644
--- a/superset/tasks/scheduler.py
+++ b/superset/tasks/scheduler.py
@@ -22,6 +22,7 @@ from typing import Any
from celery import Task
from celery.exceptions import SoftTimeLimitExceeded
+from celery.signals import task_failure
from flask import current_app
from superset import is_feature_enabled
@@ -41,8 +42,32 @@ from superset.utils.log import get_logger_from_status
logger = logging.getLogger(__name__)
-@celery_app.task(name="reports.scheduler")
-def scheduler() -> None:
+@task_failure.connect
+def log_task_failure( # pylint: disable=unused-argument
+ sender: Task | None = None,
+ task_id: str | None = None,
+ exception: Exception | None = None,
+ args: tuple[Any, ...] | None = None,
+ kwargs: dict[str, Any] | None = None,
+ traceback: Any = None,
+ einfo: Any = None,
+ **kw: Any,
+) -> None:
+ task_name = sender.name if sender else "Unknown"
+ logger.exception("Celery task %s failed: %s", task_name, exception,
exc_info=einfo)
+
+
+@celery_app.task(
+ name="reports.scheduler",
+ bind=True,
+ autoretry_for=(Exception,),
+ retry_kwargs={
+ "max_retries": 3,
+ "countdown": 60,
+ }, # Retry up to 3 times, wait 60s between
+ retry_backoff=True, # exponential backoff
+)
+def scheduler(self: Task) -> None: # pylint: disable=unused-argument
"""
Celery beat main scheduler for reports
"""
