This is an automated email from the ASF dual-hosted git repository.

msyavuz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 5a15c632ad fix(Alerts): Correct icon sizes (#35572)
5a15c632ad is described below

commit 5a15c632ad2cf20d176abff359f80a7bbdf5ac16
Author: Mehmet Salih Yavuz <[email protected]>
AuthorDate: Thu Oct 9 19:33:14 2025 +0300

    fix(Alerts): Correct icon sizes (#35572)
---
 .../src/components/Icons/AntdEnhanced.tsx                |   2 ++
 superset-frontend/src/assets/images/icons/slack.svg      | Bin 2654 -> 0 bytes
 superset-frontend/src/components/ListView/ActionsBar.tsx |   2 +-
 .../src/features/alerts/components/RecipientIcon.tsx     |   5 +++--
 4 files changed, 6 insertions(+), 3 deletions(-)

diff --git 
a/superset-frontend/packages/superset-ui-core/src/components/Icons/AntdEnhanced.tsx
 
b/superset-frontend/packages/superset-ui-core/src/components/Icons/AntdEnhanced.tsx
index fea1eec770..fe5ae1c880 100644
--- 
a/superset-frontend/packages/superset-ui-core/src/components/Icons/AntdEnhanced.tsx
+++ 
b/superset-frontend/packages/superset-ui-core/src/components/Icons/AntdEnhanced.tsx
@@ -147,6 +147,7 @@ import {
   ExportOutlined,
   CompressOutlined,
   HistoryOutlined,
+  SlackOutlined,
 } from '@ant-design/icons';
 import { FC } from 'react';
 import { IconType } from './types';
@@ -283,6 +284,7 @@ const AntdIcons = {
   ExportOutlined,
   CompressOutlined,
   HistoryOutlined,
+  SlackOutlined,
 } as const;
 
 type AntdIconNames = keyof typeof AntdIcons;
diff --git a/superset-frontend/src/assets/images/icons/slack.svg 
b/superset-frontend/src/assets/images/icons/slack.svg
deleted file mode 100644
index 3ee9ffd93e..0000000000
Binary files a/superset-frontend/src/assets/images/icons/slack.svg and 
/dev/null differ
diff --git a/superset-frontend/src/components/ListView/ActionsBar.tsx 
b/superset-frontend/src/components/ListView/ActionsBar.tsx
index e802005de7..7a4f57b7fc 100644
--- a/superset-frontend/src/components/ListView/ActionsBar.tsx
+++ b/superset-frontend/src/components/ListView/ActionsBar.tsx
@@ -86,7 +86,7 @@ export function ActionsBar({ actions }: ActionsBarProps) {
             onClick={action.onClick}
             key={action.tooltip ? undefined : index}
           >
-            <ActionIcon />
+            <ActionIcon iconSize="l" />
           </span>
         );
         return action.tooltip ? (
diff --git a/superset-frontend/src/features/alerts/components/RecipientIcon.tsx 
b/superset-frontend/src/features/alerts/components/RecipientIcon.tsx
index 2baf5c7702..229194f443 100644
--- a/superset-frontend/src/features/alerts/components/RecipientIcon.tsx
+++ b/superset-frontend/src/features/alerts/components/RecipientIcon.tsx
@@ -25,6 +25,7 @@ import { NotificationMethodOption } from '../types';
 const notificationStyledIcon = (theme: SupersetTheme) => css`
   color: ${theme.colorIcon};
   margin-right: ${theme.sizeUnit * 2}px;
+  vertical-align: middle;
 `;
 
 export default function RecipientIcon({ type }: { type: string }) {
@@ -41,13 +42,13 @@ export default function RecipientIcon({ type }: { type: 
string }) {
       break;
     case NotificationMethodOption.Slack:
       recipientIconConfig.icon = (
-        <Icons.Slack css={notificationStyledIcon} iconSize="l" />
+        <Icons.SlackOutlined css={notificationStyledIcon} iconSize="l" />
       );
       recipientIconConfig.label = NotificationMethodOption.Slack;
       break;
     case NotificationMethodOption.SlackV2:
       recipientIconConfig.icon = (
-        <Icons.Slack css={notificationStyledIcon} iconSize="l" />
+        <Icons.SlackOutlined css={notificationStyledIcon} iconSize="l" />
       );
       recipientIconConfig.label = NotificationMethodOption.Slack;
       break;

Reply via email to