This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch 5.0-extensions
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/5.0-extensions by this push:
new 5f0059bf68 fix: Extension events not fired in SQL Lab tabs (#35753)
5f0059bf68 is described below
commit 5f0059bf680150a5990ae88846e4b3d03ac96f76
Author: Michael S. Molina <[email protected]>
AuthorDate: Mon Oct 20 16:41:24 2025 -0300
fix: Extension events not fired in SQL Lab tabs (#35753)
(cherry picked from commit fa90ba976c7bb7531bec6c914f244b8bb12ab9fe)
---
superset-frontend/src/core/sqlLab/index.ts | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/superset-frontend/src/core/sqlLab/index.ts
b/superset-frontend/src/core/sqlLab/index.ts
index a81c32572b..8fcef998d7 100644
--- a/superset-frontend/src/core/sqlLab/index.ts
+++ b/superset-frontend/src/core/sqlLab/index.ts
@@ -30,7 +30,6 @@ import {
} from 'src/SqlLab/actions/sqlLab';
import { RootState, store } from 'src/views/store';
import { AnyListenerPredicate } from '@reduxjs/toolkit';
-import memoizeOne from 'memoize-one';
import type { SqlLabRootState } from 'src/SqlLab/types';
import { Disposable } from '../models';
import { createActionListener } from '../utils';
@@ -198,13 +197,10 @@ const getActiveEditorImmutableId = () => {
return activeEditor?.immutableId;
};
-// Memoized version to avoid repeated store lookups when active editor hasn't
changed
-const getActiveEditorId = memoizeOne(getActiveEditorImmutableId);
-
const predicate = (actionType: string): AnyListenerPredicate<RootState> => {
// Capture the immutable ID of the active editor at the time the listener is
created
// This ID never changes for a tab, ensuring stable event routing
- const registrationImmutableId = getActiveEditorId();
+ const registrationImmutableId = getActiveEditorImmutableId();
return action => {
if (action.type !== actionType) return false;
